zmodem wrote: We're hitting link errors after this change when building with sanitizer coverage enabled:
``` lld-link: error: relocation against symbol in discarded section: .text >>> referenced by obj/third_party/icu/icuuc_private/filteredbrk.obj:(.SCOVP$M) >>> referenced by obj/third_party/icu/icuuc_private/filteredbrk.obj:(.SCOVP$M) >>> referenced by obj/third_party/icu/icuuc_private/filteredbrk.obj:(.SCOVP$M) >>> referenced by obj/third_party/icu/icuuc_private/filteredbrk.obj:(.SCOVP$M) >>> referenced by obj/third_party/icu/icuuc_private/filteredbrk.obj:(.SCOVP$M) ``` I've added preprocessed source and compiler invocation for filteredbrk.obj here: https://crbug.com/402354446#comment6 Can you take a look? I'll revert this to unbreak things in the meantime. https://github.com/llvm/llvm-project/pull/126240 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
