arphaman added inline comments.

================
Comment at: lib/Sema/SemaAttr.cpp:578
+    return;
+  Diag(PragmaAttributeStack.back().Loc, diag::warn_pragm_attribute_no_pop_eof);
+}
----------------
aaron.ballman wrote:
> Perhaps adding a FixIt here would be a kindness?
Where would the fix-it point to? I think only the user will know the location 
at which they meant to insert `#pragma clang attribute pop`.


Repository:
  rL LLVM

https://reviews.llvm.org/D30009



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to