aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
This seems reasonable to me, but you should wait for confirmation before committing (I'm not as familiar with the mangler as others are). ================ Comment at: test/CodeGenCXX/unaligned-duplicated-mangle-name.cpp:16 +void A::foo() // expected-error {{definition with same mangled name as another definition}} + // expected-note@-6 {{previous definition is here}} +{ ---------------- Might as well put this note with the declaration rather than using an offset for the message. https://reviews.llvm.org/D31976 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits