djasper added inline comments.

================
Comment at: lib/Format/WhitespaceManager.cpp:523
+      if (C.NewlinesBefore > 0 && C.ContinuesPPDirective)
+        C.EscapedNewlineColumn = C.PreviousEndOfTokenColumn + 2;
+    return;
----------------
I think we should not duplicate this loop. Two alternatives:
1. Move this into the other loop. As long as you reset StartOfMacro in each 
iteration, it should do the right thing.
2. Make this work if we just return here. In theory, the "\" should not need 
any special-casing with this style.

I'd prefer #2.


https://reviews.llvm.org/D32733



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to