rnkovacs added a comment.

In https://reviews.llvm.org/D32700#743178, @malcolm.parsons wrote:

> Can you change this to match any pointer to a class with a virtual function?


Well, I have just found a clang flag `-Wdynamic-class-memaccess` 
<https://clang.llvm.org/docs/DiagnosticsReference.html#wdynamic-class-memaccess>
  that finds all of these cases and is enabled by default. I guess I need to 
drop the `this` case entirely.

> I'd also like a warning for a pointer to a class with a constructor or 
> destructor.

This is a nice idea, I'll do it.


https://reviews.llvm.org/D32700



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to