majnemer added inline comments.
================
Comment at: include/support/win32/msvc_builtin_support.h:33
+
+_LIBCPP_ALWAYS_INLINE int __builtin_popcount(unsigned int x)
+{
----------------
compnerd wrote:
> I think I prefer the following implementation:
>
> _LIBCPP_ALWAYS_INLINE int __builtin_popcount(unsigned int value) {
> return __popcnt(value);
> }
I think it'd be better not to call it `__builtin_anything`. MSVC uses the
__builtin_ namespace too, see https://godbolt.org/g/HwMskX
Maybe create a wrapper called `__libcpp_popcount`?
https://reviews.llvm.org/D32988
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
