mcinally wrote: > > I had 1 minor objection, see my concern on the `uninitialized` attribute > > removal. > > Would it be simpler just to initialize the variable before use? I assume that > the attribute is present to eliminate compiler warnings about uninitialized > variables being passed by reference. I don't see the use of this anywhere > else in the code base. Does adding that attribute really provide a great deal > of meaningful context?
This is looking like a better option. Some CIs don't seem to pick up the macro. I'll do some investigating, but I'm not able to reproduce with my build. https://github.com/llvm/llvm-project/pull/142800 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
