[clang] [Clang] _default-movable_ should be based on the first declaration (PR #143661)

[Aaron Ballman via cfe-commits]

================
@@ -2045,6 +2047,8 @@ static void DiagnoseNonDefaultMovable(Sema &SemaRef, 
SourceLocation Loc,
           << Decl->isMoveAssignmentOperator() << Decl->getSourceRange();
   }
   CXXDestructorDecl *Dtr = D->getDestructor();
+  if (Dtr)
----------------
AaronBallman wrote:

I think this is a bit clearer as:
```
if (const CXXDestructorDecl *Dtor = D->getDestructor()) {
  Dtor = Dtor->getCanonicalDecl();
  if (Dtr->isUserProvided() && !Dtr->isDefaulted()) {
    SemaRef.Diag(Loc, diag::note_unsatisfied_trait_reason)
        << diag::TraitNotSatisfiedReason::DeletedDtr << /*User Provided*/ 1
        << Dtr->getSourceRange();
  }
}
```

https://github.com/llvm/llvm-project/pull/143661
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits