https://github.com/erichkeane commented:
I find myself wondering based on the patch: DO we actually care about the token itself, or just the kind? Could we instead have `peekNextPPToken` instead be `peekNextPPTokenKind` and just return the next token kind? That way we don't need the optional, and can just do a direct comparison. We could also just return the `eof` as well rather than treating that as a nullopt. WDYT? https://github.com/llvm/llvm-project/pull/143898 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
