joerg added inline comments.

================
Comment at: lib/Basic/Targets.cpp:7614
+      resetDataLayout(("e-" + Layout).str());
+    }
+  }
----------------
Can you just give the full string and avoid the runtime allocations?


================
Comment at: lib/Basic/Targets.cpp:7650
+    DefineStd(Builder, "nios2", Opts);
+    DefineStd(Builder, "NIOS2", Opts);
+
----------------
DefineStd tends to give a lot of namespace pollution, is that intentional here?


https://reviews.llvm.org/D33356



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to