bruno marked 3 inline comments as done.
bruno added a comment.

> I think the problem is that we don't take module visibility into account when 
> doing redefinition checking for enumerators. Instead of passing through this 
> flag, we should probably just ignore hidden declarations when checking for a 
> redefinition of an enumerator.

Right, now that the patch changed to only merge the definition after the 
structural check it does makes sense to do that.


https://reviews.llvm.org/D31778



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to