llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) <details> <summary>Changes</summary> --- Full diff: https://github.com/llvm/llvm-project/pull/144250.diff 4 Files Affected: - (modified) clang/utils/TableGen/ClangCommentCommandInfoEmitter.cpp (+5-6) - (modified) clang/utils/TableGen/ClangCommentHTMLNamedCharacterReferenceEmitter.cpp (+2-2) - (modified) clang/utils/TableGen/ClangDiagnosticsEmitter.cpp (+2-2) - (modified) clang/utils/TableGen/ClangOpcodesEmitter.cpp (+1-2) ``````````diff diff --git a/clang/utils/TableGen/ClangCommentCommandInfoEmitter.cpp b/clang/utils/TableGen/ClangCommentCommandInfoEmitter.cpp index f15e30cd3f8f4..161dd425fbc7b 100644 --- a/clang/utils/TableGen/ClangCommentCommandInfoEmitter.cpp +++ b/clang/utils/TableGen/ClangCommentCommandInfoEmitter.cpp @@ -78,10 +78,10 @@ void clang::EmitClangCommentCommandInfo(const RecordKeeper &Records, static std::string MangleName(StringRef Str) { std::string Mangled; - for (unsigned i = 0, e = Str.size(); i != e; ++i) { - switch (Str[i]) { + for (char C : Str) { + switch (C) { default: - Mangled += Str[i]; + Mangled += C; break; case '(': Mangled += "lparen"; @@ -122,9 +122,8 @@ void clang::EmitClangCommentCommandList(const RecordKeeper &Records, << "#endif\n"; ArrayRef<const Record *> Tags = Records.getAllDerivedDefinitions("Command"); - for (size_t i = 0, e = Tags.size(); i != e; ++i) { - const Record &Tag = *Tags[i]; - std::string MangledName = MangleName(Tag.getValueAsString("Name")); + for (const Record *Tag : Tags) { + std::string MangledName = MangleName(Tag->getValueAsString("Name")); OS << "COMMENT_COMMAND(" << MangledName << ")\n"; } diff --git a/clang/utils/TableGen/ClangCommentHTMLNamedCharacterReferenceEmitter.cpp b/clang/utils/TableGen/ClangCommentHTMLNamedCharacterReferenceEmitter.cpp index b8d8ac853a5c0..e5eec5e7ca8d4 100644 --- a/clang/utils/TableGen/ClangCommentHTMLNamedCharacterReferenceEmitter.cpp +++ b/clang/utils/TableGen/ClangCommentHTMLNamedCharacterReferenceEmitter.cpp @@ -37,9 +37,9 @@ static bool translateCodePointToUTF8(unsigned CodePoint, raw_svector_ostream OS(CLiteral); OS << "\""; - for (size_t i = 0, e = UTF8.size(); i != e; ++i) { + for (char C : UTF8) { OS << "\\x"; - OS.write_hex(static_cast<unsigned char>(UTF8[i])); + OS.write_hex(static_cast<unsigned char>(C)); } OS << "\""; diff --git a/clang/utils/TableGen/ClangDiagnosticsEmitter.cpp b/clang/utils/TableGen/ClangDiagnosticsEmitter.cpp index e347b89a85d46..bfc60f485cd32 100644 --- a/clang/utils/TableGen/ClangDiagnosticsEmitter.cpp +++ b/clang/utils/TableGen/ClangDiagnosticsEmitter.cpp @@ -1794,8 +1794,8 @@ static std::string getDiagCategoryEnum(StringRef name) { if (name.empty()) return "DiagCat_None"; SmallString<256> enumName = StringRef("DiagCat_"); - for (StringRef::iterator I = name.begin(), E = name.end(); I != E; ++I) - enumName += isalnum(*I) ? *I : '_'; + for (char C : name) + enumName += isalnum(C) ? C : '_'; return std::string(enumName); } diff --git a/clang/utils/TableGen/ClangOpcodesEmitter.cpp b/clang/utils/TableGen/ClangOpcodesEmitter.cpp index 5d6d90994cf37..9d0773e1aff8f 100644 --- a/clang/utils/TableGen/ClangOpcodesEmitter.cpp +++ b/clang/utils/TableGen/ClangOpcodesEmitter.cpp @@ -224,8 +224,7 @@ void ClangOpcodesEmitter::EmitProto(raw_ostream &OS, StringRef N, auto Args = R->getValueAsListOfDefs("Args"); Enumerate(R, N, [&OS, &Args](ArrayRef<const Record *> TS, const Twine &ID) { OS << "bool emit" << ID << "("; - for (size_t I = 0, N = Args.size(); I < N; ++I) { - const auto *Arg = Args[I]; + for (const Record *Arg : Args) { bool AsRef = Arg->getValueAsBit("AsRef"); auto Name = Arg->getValueAsString("Name"); `````````` </details> https://github.com/llvm/llvm-project/pull/144250 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
