https://github.com/stellar-aria updated
https://github.com/llvm/llvm-project/pull/127430
>From 4d60b545cb902d864221342e73cc61e2d728f73d Mon Sep 17 00:00:00 2001
From: Katherine Whitlock <k...@skylinesynths.nyc>
Date: Sun, 15 Jun 2025 11:47:04 -0400
Subject: [PATCH 1/4] [clang-tidy] Add new check
`readability-use-numeric-limits`
---
.../clang-tidy/readability/CMakeLists.txt | 1 +
.../readability/ReadabilityTidyModule.cpp | 3 +
.../readability/UseNumericLimitsCheck.cpp | 163 ++++++++++++++++++
.../readability/UseNumericLimitsCheck.h | 38 ++++
clang-tools-extra/docs/ReleaseNotes.rst | 11 ++
.../docs/clang-tidy/checks/list.rst | 1 +
.../checks/readability/use-numeric-limits.rst | 31 ++++
.../readability/use-numeric-limits.cpp | 90 ++++++++++
8 files changed, 338 insertions(+)
create mode 100644
clang-tools-extra/clang-tidy/readability/UseNumericLimitsCheck.cpp
create mode 100644
clang-tools-extra/clang-tidy/readability/UseNumericLimitsCheck.h
create mode 100644
clang-tools-extra/docs/clang-tidy/checks/readability/use-numeric-limits.rst
create mode 100644
clang-tools-extra/test/clang-tidy/checkers/readability/use-numeric-limits.cpp
diff --git a/clang-tools-extra/clang-tidy/readability/CMakeLists.txt
b/clang-tools-extra/clang-tidy/readability/CMakeLists.txt
index 4be1a8f831339..2c40a863c5b7d 100644
--- a/clang-tools-extra/clang-tidy/readability/CMakeLists.txt
+++ b/clang-tools-extra/clang-tidy/readability/CMakeLists.txt
@@ -58,6 +58,7 @@ add_clang_library(clangTidyReadabilityModule STATIC
UniqueptrDeleteReleaseCheck.cpp
UppercaseLiteralSuffixCheck.cpp
UseAnyOfAllOfCheck.cpp
+ UseNumericLimitsCheck.cpp
UseStdMinMaxCheck.cpp
LINK_LIBS
diff --git a/clang-tools-extra/clang-tidy/readability/ReadabilityTidyModule.cpp
b/clang-tools-extra/clang-tidy/readability/ReadabilityTidyModule.cpp
index d59b0312673b9..dc47c2fb31937 100644
--- a/clang-tools-extra/clang-tidy/readability/ReadabilityTidyModule.cpp
+++ b/clang-tools-extra/clang-tidy/readability/ReadabilityTidyModule.cpp
@@ -61,6 +61,7 @@
#include "UniqueptrDeleteReleaseCheck.h"
#include "UppercaseLiteralSuffixCheck.h"
#include "UseAnyOfAllOfCheck.h"
+#include "UseNumericLimitsCheck.h"
#include "UseStdMinMaxCheck.h"
namespace clang::tidy {
@@ -173,6 +174,8 @@ class ReadabilityModule : public ClangTidyModule {
"readability-uppercase-literal-suffix");
CheckFactories.registerCheck<UseAnyOfAllOfCheck>(
"readability-use-anyofallof");
+ CheckFactories.registerCheck<UseNumericLimitsCheck>(
+ "readability-use-numeric-limits");
CheckFactories.registerCheck<UseStdMinMaxCheck>(
"readability-use-std-min-max");
}
diff --git a/clang-tools-extra/clang-tidy/readability/UseNumericLimitsCheck.cpp
b/clang-tools-extra/clang-tidy/readability/UseNumericLimitsCheck.cpp
new file mode 100644
index 0000000000000..b263d12738ce2
--- /dev/null
+++ b/clang-tools-extra/clang-tidy/readability/UseNumericLimitsCheck.cpp
@@ -0,0 +1,163 @@
+//===--- UseNumericLimitsCheck.cpp - clang-tidy
---------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "UseNumericLimitsCheck.h"
+#include "clang/AST/ASTContext.h"
+#include "clang/ASTMatchers/ASTMatchFinder.h"
+#include "clang/Lex/Preprocessor.h"
+#include <cmath>
+#include <limits>
+
+using namespace clang::ast_matchers;
+
+namespace clang::tidy::readability {
+
+UseNumericLimitsCheck::UseNumericLimitsCheck(StringRef Name,
+ ClangTidyContext *Context)
+ : ClangTidyCheck(Name, Context),
+ SignedConstants{
+ {std::numeric_limits<int8_t>::min(),
+ "std::numeric_limits<int8_t>::min()"},
+ {std::numeric_limits<int8_t>::max(),
+ "std::numeric_limits<int8_t>::max()"},
+ {std::numeric_limits<int16_t>::min(),
+ "std::numeric_limits<int16_t>::min()"},
+ {std::numeric_limits<int16_t>::max(),
+ "std::numeric_limits<int16_t>::max()"},
+ {std::numeric_limits<int32_t>::min(),
+ "std::numeric_limits<int32_t>::min()"},
+ {std::numeric_limits<int32_t>::max(),
+ "std::numeric_limits<int32_t>::max()"},
+ {std::numeric_limits<int64_t>::min(),
+ "std::numeric_limits<int64_t>::min()"},
+ {std::numeric_limits<int64_t>::max(),
+ "std::numeric_limits<int64_t>::max()"},
+ },
+ UnsignedConstants{
+ {std::numeric_limits<uint8_t>::max(),
+ "std::numeric_limits<uint8_t>::max()"},
+ {std::numeric_limits<uint16_t>::max(),
+ "std::numeric_limits<uint16_t>::max()"},
+ {std::numeric_limits<uint32_t>::max(),
+ "std::numeric_limits<uint32_t>::max()"},
+ {std::numeric_limits<uint64_t>::max(),
+ "std::numeric_limits<uint64_t>::max()"},
+ },
+ Inserter(Options.getLocalOrGlobal("IncludeStyle",
+ utils::IncludeSorter::IS_LLVM),
+ areDiagsSelfContained()) {}
+
+void UseNumericLimitsCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {
+ Options.store(Opts, "IncludeStyle", Inserter.getStyle());
+}
+
+void UseNumericLimitsCheck::registerMatchers(MatchFinder *Finder) {
+ auto PositiveIntegerMatcher = [](auto Value) {
+ return unaryOperator(hasOperatorName("+"),
+ hasUnaryOperand(integerLiteral(equals(Value))
+
.bind("positive-integer-literal")))
+ .bind("unary-op");
+ };
+
+ auto NegativeIntegerMatcher = [](auto Value) {
+ return unaryOperator(hasOperatorName("-"),
+ hasUnaryOperand(integerLiteral(equals(-Value))
+
.bind("negative-integer-literal")))
+ .bind("unary-op");
+ };
+
+ auto BareIntegerMatcher = [](auto Value) {
+ return integerLiteral(allOf(unless(hasParent(unaryOperator(
+ hasAnyOperatorName("-", "+")))),
+ equals(Value)))
+ .bind("bare-integer-literal");
+ };
+
+ for (const auto &[Value, _] : SignedConstants) {
+ if (Value < 0) {
+ Finder->addMatcher(NegativeIntegerMatcher(Value), this);
+ } else {
+ Finder->addMatcher(
+ expr(anyOf(PositiveIntegerMatcher(Value),
BareIntegerMatcher(Value))),
+ this);
+ }
+ }
+
+ for (const auto &[Value, _] : UnsignedConstants) {
+ Finder->addMatcher(
+ expr(anyOf(PositiveIntegerMatcher(Value), BareIntegerMatcher(Value))),
+ this);
+ }
+}
+
+void UseNumericLimitsCheck::registerPPCallbacks(
+ const SourceManager &SM, Preprocessor *PP, Preprocessor *ModuleExpanderPP)
{
+ Inserter.registerPreprocessor(PP);
+}
+
+void UseNumericLimitsCheck::check(const MatchFinder::MatchResult &Result) {
+ const IntegerLiteral *MatchedDecl = nullptr;
+
+ const IntegerLiteral *NegativeMatchedDecl =
+ Result.Nodes.getNodeAs<IntegerLiteral>("negative-integer-literal");
+ const IntegerLiteral *PositiveMatchedDecl =
+ Result.Nodes.getNodeAs<IntegerLiteral>("positive-integer-literal");
+ const IntegerLiteral *BareMatchedDecl =
+ Result.Nodes.getNodeAs<IntegerLiteral>("bare-integer-literal");
+
+ if (NegativeMatchedDecl != nullptr) {
+ MatchedDecl = NegativeMatchedDecl;
+ } else if (PositiveMatchedDecl != nullptr) {
+ MatchedDecl = PositiveMatchedDecl;
+ } else if (BareMatchedDecl != nullptr) {
+ MatchedDecl = BareMatchedDecl;
+ }
+
+ const llvm::APInt MatchedIntegerConstant = MatchedDecl->getValue();
+
+ auto Fixer = [&](auto SourceValue, auto Value,
+ const std::string &Replacement) {
+ static_assert(std::is_same_v<decltype(SourceValue), decltype(Value)>,
+ "The types of SourceValue and Value must match");
+
+ SourceLocation Location = MatchedDecl->getExprLoc();
+ SourceRange Range{MatchedDecl->getBeginLoc(), MatchedDecl->getEndLoc()};
+
+ // Only valid if unary operator is present
+ const UnaryOperator *UnaryOpExpr =
+ Result.Nodes.getNodeAs<UnaryOperator>("unary-op");
+
+ if (MatchedDecl == NegativeMatchedDecl && -SourceValue == Value) {
+ Range = SourceRange(UnaryOpExpr->getBeginLoc(),
UnaryOpExpr->getEndLoc());
+ Location = UnaryOpExpr->getExprLoc();
+ SourceValue = -SourceValue;
+ } else if (MatchedDecl == PositiveMatchedDecl && SourceValue == Value) {
+ Range = SourceRange(UnaryOpExpr->getBeginLoc(),
UnaryOpExpr->getEndLoc());
+ Location = UnaryOpExpr->getExprLoc();
+ } else if (MatchedDecl != BareMatchedDecl || SourceValue != Value) {
+ return;
+ }
+
+ diag(Location,
+ "The constant %0 is being utilized. Consider using %1 instead")
+ << std::to_string(SourceValue) << Replacement
+ << FixItHint::CreateReplacement(Range, Replacement)
+ << Inserter.createIncludeInsertion(
+ Result.SourceManager->getFileID(Location), "<limits>");
+ };
+
+ for (const auto &[Value, Replacement] : SignedConstants) {
+ Fixer(MatchedIntegerConstant.getSExtValue(), Value, Replacement);
+ }
+
+ for (const auto &[Value, Replacement] : UnsignedConstants) {
+ Fixer(MatchedIntegerConstant.getZExtValue(), Value, Replacement);
+ }
+}
+
+} // namespace clang::tidy::readability
diff --git a/clang-tools-extra/clang-tidy/readability/UseNumericLimitsCheck.h
b/clang-tools-extra/clang-tidy/readability/UseNumericLimitsCheck.h
new file mode 100644
index 0000000000000..62fb181258ae4
--- /dev/null
+++ b/clang-tools-extra/clang-tidy/readability/UseNumericLimitsCheck.h
@@ -0,0 +1,38 @@
+//===--- UseNumericLimitsCheck.h - clang-tidy -------------------*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_READABILITY_USENUMERICLIMITSCHECK_H
+#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_READABILITY_USENUMERICLIMITSCHECK_H
+
+#include "../ClangTidyCheck.h"
+#include "../utils/IncludeInserter.h"
+
+namespace clang::tidy::readability {
+
+/// Replaces certain integer literals with equivalent calls to
+/// ``std::numeric_limits``.
+/// For the user-facing documentation see:
+///
http://clang.llvm.org/extra/clang-tidy/checks/readability/use-numeric-limits.html
+class UseNumericLimitsCheck : public ClangTidyCheck {
+public:
+ UseNumericLimitsCheck(StringRef Name, ClangTidyContext *Context);
+ void storeOptions(ClangTidyOptions::OptionMap &Opts) override;
+ void registerMatchers(ast_matchers::MatchFinder *Finder) override;
+ void registerPPCallbacks(const SourceManager &SM, Preprocessor *PP,
+ Preprocessor *ModuleExpanderPP) override;
+ void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
+
+private:
+ const llvm::SmallVector<std::pair<int64_t, std::string>> SignedConstants;
+ const llvm::SmallVector<std::pair<uint64_t, std::string>> UnsignedConstants;
+ utils::IncludeInserter Inserter;
+};
+
+} // namespace clang::tidy::readability
+
+#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_READABILITY_USENUMERICLIMITSCHECK_H
diff --git a/clang-tools-extra/docs/ReleaseNotes.rst
b/clang-tools-extra/docs/ReleaseNotes.rst
index 19ccd1790e757..ea7514d02cd18 100644
--- a/clang-tools-extra/docs/ReleaseNotes.rst
+++ b/clang-tools-extra/docs/ReleaseNotes.rst
@@ -117,6 +117,13 @@ Improvements to clang-tidy
New checks
^^^^^^^^^^
+- New :doc:`readability-use-numeric-limits
+ <clang-tidy/checks/readability/use-numeric-limits>` check.
+
+ Replaces certain integer literals with equivalent calls to
+ ``std::numeric_limits<T>::min()`` or ``std::numeric_limits<T>::max()``.
+
+
- New :doc:`bugprone-capturing-this-in-member-variable
<clang-tidy/checks/bugprone/capturing-this-in-member-variable>` check.
@@ -148,6 +155,10 @@ New checks
Finds potentially erroneous calls to ``reset`` method on smart pointers when
the pointee type also has a ``reset`` method.
+- New :doc:`readability-use-numeric-limits
+ <clang-tidy/checks/readability/use-numeric-limits>` check to replace certain
+ integer literals with ``std::numeric_limits`` calls.
+
New check aliases
^^^^^^^^^^^^^^^^^
diff --git a/clang-tools-extra/docs/clang-tidy/checks/list.rst
b/clang-tools-extra/docs/clang-tidy/checks/list.rst
index 5a79d61b1fd7e..e6f25f839b26a 100644
--- a/clang-tools-extra/docs/clang-tidy/checks/list.rst
+++ b/clang-tools-extra/docs/clang-tidy/checks/list.rst
@@ -408,6 +408,7 @@ Clang-Tidy Checks
:doc:`readability-uniqueptr-delete-release
<readability/uniqueptr-delete-release>`, "Yes"
:doc:`readability-uppercase-literal-suffix
<readability/uppercase-literal-suffix>`, "Yes"
:doc:`readability-use-anyofallof <readability/use-anyofallof>`,
+ :doc:`readability-use-numeric-limits <readability/use-numeric-limits>`,
"Yes"
:doc:`readability-use-std-min-max <readability/use-std-min-max>`, "Yes"
:doc:`zircon-temporary-objects <zircon/temporary-objects>`,
diff --git
a/clang-tools-extra/docs/clang-tidy/checks/readability/use-numeric-limits.rst
b/clang-tools-extra/docs/clang-tidy/checks/readability/use-numeric-limits.rst
new file mode 100644
index 0000000000000..0dfc29c4b95ae
--- /dev/null
+++
b/clang-tools-extra/docs/clang-tidy/checks/readability/use-numeric-limits.rst
@@ -0,0 +1,31 @@
+.. title:: clang-tidy - readability-use-numeric-limits
+
+readability-use-numeric-limits
+==============================
+
+ Replaces certain integer literals with equivalent calls to
+ ``std::numeric_limits<T>::min()`` or ``std::numeric_limits<T>::max()``.
+
+Before:
+
+.. code-block:: c++
+
+ void foo() {
+ int32_t a = 2147483647;
+ }
+
+After:
+
+.. code-block:: c++
+
+ void foo() {
+ int32_t a = std::numeric_limits<int32_t>::max();
+ }
+
+Options
+-------
+
+.. option:: IncludeStyle
+
+ A string specifying which include-style is used, `llvm` or `google`. Default
+ is `llvm`.
diff --git
a/clang-tools-extra/test/clang-tidy/checkers/readability/use-numeric-limits.cpp
b/clang-tools-extra/test/clang-tidy/checkers/readability/use-numeric-limits.cpp
new file mode 100644
index 0000000000000..794dfcea00a52
--- /dev/null
+++
b/clang-tools-extra/test/clang-tidy/checkers/readability/use-numeric-limits.cpp
@@ -0,0 +1,90 @@
+// RUN: %check_clang_tidy %s readability-use-numeric-limits %t
+#include <stdint.h>
+
+void Invalid() {
+ // CHECK-MESSAGES: :[[@LINE+2]]:14: warning: The constant -128 is being
utilized. Consider using std::numeric_limits<int8_t>::min() instead
[readability-use-numeric-limits]
+ // CHECK-FIXES: int8_t a = std::numeric_limits<int8_t>::min();
+ int8_t a = -128;
+
+ // CHECK-MESSAGES: :[[@LINE+2]]:14: warning: The constant 127 is being
utilized. Consider using std::numeric_limits<int8_t>::max() instead
[readability-use-numeric-limits]
+ // CHECK-FIXES: int8_t b = std::numeric_limits<int8_t>::max();
+ int8_t b = +127;
+
+ // CHECK-MESSAGES: :[[@LINE+2]]:14: warning: The constant 127 is being
utilized. Consider using std::numeric_limits<int8_t>::max() instead
[readability-use-numeric-limits]
+ // CHECK-FIXES: int8_t c = std::numeric_limits<int8_t>::max();
+ int8_t c = 127;
+
+ // CHECK-MESSAGES: :[[@LINE+2]]:15: warning: The constant -32768 is being
utilized. Consider using std::numeric_limits<int16_t>::min() instead
[readability-use-numeric-limits]
+ // CHECK-FIXES: int16_t d = std::numeric_limits<int16_t>::min();
+ int16_t d = -32768;
+
+ // CHECK-MESSAGES: :[[@LINE+2]]:15: warning: The constant 32767 is being
utilized. Consider using std::numeric_limits<int16_t>::max() instead
[readability-use-numeric-limits]
+ // CHECK-FIXES: int16_t e = std::numeric_limits<int16_t>::max();
+ int16_t e = +32767;
+
+ // CHECK-MESSAGES: :[[@LINE+2]]:15: warning: The constant 32767 is being
utilized. Consider using std::numeric_limits<int16_t>::max() instead
[readability-use-numeric-limits]
+ // CHECK-FIXES: int16_t f = std::numeric_limits<int16_t>::max();
+ int16_t f = 32767;
+
+ // CHECK-MESSAGES: :[[@LINE+2]]:15: warning: The constant -2147483648 is
being utilized. Consider using std::numeric_limits<int32_t>::min() instead
[readability-use-numeric-limits]
+ // CHECK-FIXES: int32_t g = std::numeric_limits<int32_t>::min();
+ int32_t g = -2147483648;
+
+ // CHECK-MESSAGES: :[[@LINE+2]]:15: warning: The constant 2147483647 is
being utilized. Consider using std::numeric_limits<int32_t>::max() instead
[readability-use-numeric-limits]
+ // CHECK-FIXES: int32_t h = std::numeric_limits<int32_t>::max();
+ int32_t h = +2147483647;
+
+ // CHECK-MESSAGES: :[[@LINE+2]]:15: warning: The constant 2147483647 is
being utilized. Consider using std::numeric_limits<int32_t>::max() instead
[readability-use-numeric-limits]
+ // CHECK-FIXES: int32_t i = std::numeric_limits<int32_t>::max();
+ int32_t i = 2147483647;
+
+ // CHECK-MESSAGES: :[[@LINE+2]]:15: warning: The constant
-9223372036854775808 is being utilized. Consider using
std::numeric_limits<int64_t>::min() instead [readability-use-numeric-limits]
+ // CHECK-FIXES: int64_t j = std::numeric_limits<int64_t>::min();
+ int64_t j = -9223372036854775808;
+
+ // CHECK-MESSAGES: :[[@LINE+2]]:15: warning: The constant
9223372036854775807 is being utilized. Consider using
std::numeric_limits<int64_t>::max() instead [readability-use-numeric-limits]
+ // CHECK-FIXES: int64_t k = std::numeric_limits<int64_t>::max();
+ int64_t k = +9223372036854775807;
+
+ // CHECK-MESSAGES: :[[@LINE+2]]:15: warning: The constant
9223372036854775807 is being utilized. Consider using
std::numeric_limits<int64_t>::max() instead [readability-use-numeric-limits]
+ // CHECK-FIXES: int64_t l = std::numeric_limits<int64_t>::max();
+ int64_t l = 9223372036854775807;
+
+ // CHECK-MESSAGES: :[[@LINE+2]]:15: warning: The constant 255 is being
utilized. Consider using std::numeric_limits<uint8_t>::max() instead
[readability-use-numeric-limits]
+ // CHECK-FIXES: uint8_t m = std::numeric_limits<uint8_t>::max();
+ uint8_t m = 255;
+
+ // CHECK-MESSAGES: :[[@LINE+2]]:15: warning: The constant 255 is being
utilized. Consider using std::numeric_limits<uint8_t>::max() instead
[readability-use-numeric-limits]
+ // CHECK-FIXES: uint8_t n = std::numeric_limits<uint8_t>::max();
+ uint8_t n = +255;
+
+ // CHECK-MESSAGES: :[[@LINE+2]]:16: warning: The constant 65535 is being
utilized. Consider using std::numeric_limits<uint16_t>::max() instead
[readability-use-numeric-limits]
+ // CHECK-FIXES: uint16_t o = std::numeric_limits<uint16_t>::max();
+ uint16_t o = 65535;
+
+ // CHECK-MESSAGES: :[[@LINE+2]]:16: warning: The constant 65535 is being
utilized. Consider using std::numeric_limits<uint16_t>::max() instead
[readability-use-numeric-limits]
+ // CHECK-FIXES: uint16_t p = std::numeric_limits<uint16_t>::max();
+ uint16_t p = +65535;
+
+ // CHECK-MESSAGES: :[[@LINE+2]]:16: warning: The constant 4294967295 is
being utilized. Consider using std::numeric_limits<uint32_t>::max() instead
[readability-use-numeric-limits]
+ // CHECK-FIXES: uint32_t q = std::numeric_limits<uint32_t>::max();
+ uint32_t q = 4294967295;
+
+ // CHECK-MESSAGES: :[[@LINE+2]]:16: warning: The constant 4294967295 is
being utilized. Consider using std::numeric_limits<uint32_t>::max() instead
[readability-use-numeric-limits]
+ // CHECK-FIXES: uint32_t r = std::numeric_limits<uint32_t>::max();
+ uint32_t r = +4294967295;
+
+ // CHECK-MESSAGES: :[[@LINE+2]]:16: warning: The constant
18446744073709551615 is being utilized. Consider using
std::numeric_limits<uint64_t>::max() instead [readability-use-numeric-limits]
+ // CHECK-FIXES: uint64_t s = std::numeric_limits<uint64_t>::max();
+ uint64_t s = 18446744073709551615;
+
+ // CHECK-MESSAGES: :[[@LINE+2]]:16: warning: The constant
18446744073709551615 is being utilized. Consider using
std::numeric_limits<uint64_t>::max() instead [readability-use-numeric-limits]
+ // CHECK-FIXES: uint64_t t = std::numeric_limits<uint64_t>::max();
+ uint64_t t = +18446744073709551615;
+}
+
+void Valid(){
+ int16_t a = +128;
+
+ int16_t b = -127;
+}
>From c40ef8d15f5ab2c033e1342f962e3de3a33b2997 Mon Sep 17 00:00:00 2001
From: Katherine Whitlock <k...@skylinesynths.nyc>
Date: Sun, 15 Jun 2025 12:02:18 -0400
Subject: [PATCH 2/4] Fix release note duplicate entry
---
clang-tools-extra/docs/ReleaseNotes.rst | 7 -------
1 file changed, 7 deletions(-)
diff --git a/clang-tools-extra/docs/ReleaseNotes.rst
b/clang-tools-extra/docs/ReleaseNotes.rst
index ea7514d02cd18..6284ad2e10c5d 100644
--- a/clang-tools-extra/docs/ReleaseNotes.rst
+++ b/clang-tools-extra/docs/ReleaseNotes.rst
@@ -117,13 +117,6 @@ Improvements to clang-tidy
New checks
^^^^^^^^^^
-- New :doc:`readability-use-numeric-limits
- <clang-tidy/checks/readability/use-numeric-limits>` check.
-
- Replaces certain integer literals with equivalent calls to
- ``std::numeric_limits<T>::min()`` or ``std::numeric_limits<T>::max()``.
-
-
- New :doc:`bugprone-capturing-this-in-member-variable
<clang-tidy/checks/bugprone/capturing-this-in-member-variable>` check.
>From 332ceb918d88bf2858ec0fbd0f11595df02ac8d7 Mon Sep 17 00:00:00 2001
From: Katherine Whitlock <k...@skylinesynths.nyc>
Date: Sun, 15 Jun 2025 12:03:57 -0400
Subject: [PATCH 3/4] Apply suggestions from code review
Co-authored-by: Baranov Victor <bar.victor.2...@gmail.com>
---
.../clang-tidy/readability/UseNumericLimitsCheck.cpp | 2 +-
.../docs/clang-tidy/checks/readability/use-numeric-limits.rst | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/clang-tools-extra/clang-tidy/readability/UseNumericLimitsCheck.cpp
b/clang-tools-extra/clang-tidy/readability/UseNumericLimitsCheck.cpp
index b263d12738ce2..edf1e742b0be1 100644
--- a/clang-tools-extra/clang-tidy/readability/UseNumericLimitsCheck.cpp
+++ b/clang-tools-extra/clang-tidy/readability/UseNumericLimitsCheck.cpp
@@ -144,7 +144,7 @@ void UseNumericLimitsCheck::check(const
MatchFinder::MatchResult &Result) {
}
diag(Location,
- "The constant %0 is being utilized. Consider using %1 instead")
+ "the constant '%0' is being utilized; consider using '%1' instead")
<< std::to_string(SourceValue) << Replacement
<< FixItHint::CreateReplacement(Range, Replacement)
<< Inserter.createIncludeInsertion(
diff --git
a/clang-tools-extra/docs/clang-tidy/checks/readability/use-numeric-limits.rst
b/clang-tools-extra/docs/clang-tidy/checks/readability/use-numeric-limits.rst
index 0dfc29c4b95ae..d25b553d1cda1 100644
---
a/clang-tools-extra/docs/clang-tidy/checks/readability/use-numeric-limits.rst
+++
b/clang-tools-extra/docs/clang-tidy/checks/readability/use-numeric-limits.rst
@@ -3,8 +3,8 @@
readability-use-numeric-limits
==============================
- Replaces certain integer literals with equivalent calls to
- ``std::numeric_limits<T>::min()`` or ``std::numeric_limits<T>::max()``.
+Replaces certain integer literals with equivalent calls to
+``std::numeric_limits<T>::min()`` or ``std::numeric_limits<T>::max()``.
Before:
>From a50096189645e93fcea5bf4e464a6979650fcf57 Mon Sep 17 00:00:00 2001
From: Katherine Whitlock <k...@skylinesynths.nyc>
Date: Sun, 15 Jun 2025 12:16:27 -0400
Subject: [PATCH 4/4] Fix tests and docs
---
.../readability/UseNumericLimitsCheck.cpp | 2 +-
clang-tools-extra/docs/ReleaseNotes.rst | 6 ++-
.../readability/use-numeric-limits.cpp | 40 +++++++++----------
3 files changed, 25 insertions(+), 23 deletions(-)
diff --git a/clang-tools-extra/clang-tidy/readability/UseNumericLimitsCheck.cpp
b/clang-tools-extra/clang-tidy/readability/UseNumericLimitsCheck.cpp
index edf1e742b0be1..ac714ab71d269 100644
--- a/clang-tools-extra/clang-tidy/readability/UseNumericLimitsCheck.cpp
+++ b/clang-tools-extra/clang-tidy/readability/UseNumericLimitsCheck.cpp
@@ -145,7 +145,7 @@ void UseNumericLimitsCheck::check(const
MatchFinder::MatchResult &Result) {
diag(Location,
"the constant '%0' is being utilized; consider using '%1' instead")
- << std::to_string(SourceValue) << Replacement
+ << SourceValue << Replacement
<< FixItHint::CreateReplacement(Range, Replacement)
<< Inserter.createIncludeInsertion(
Result.SourceManager->getFileID(Location), "<limits>");
diff --git a/clang-tools-extra/docs/ReleaseNotes.rst
b/clang-tools-extra/docs/ReleaseNotes.rst
index 6284ad2e10c5d..e8d9510038394 100644
--- a/clang-tools-extra/docs/ReleaseNotes.rst
+++ b/clang-tools-extra/docs/ReleaseNotes.rst
@@ -149,8 +149,10 @@ New checks
the pointee type also has a ``reset`` method.
- New :doc:`readability-use-numeric-limits
- <clang-tidy/checks/readability/use-numeric-limits>` check to replace certain
- integer literals with ``std::numeric_limits`` calls.
+ <clang-tidy/checks/readability/use-numeric-limits>` check.
+
+ Finds certain integer literals and suggests replacing them with equivalent
+ ``std::numeric_limits`` calls.
New check aliases
^^^^^^^^^^^^^^^^^
diff --git
a/clang-tools-extra/test/clang-tidy/checkers/readability/use-numeric-limits.cpp
b/clang-tools-extra/test/clang-tidy/checkers/readability/use-numeric-limits.cpp
index 794dfcea00a52..fc87eb040a70f 100644
---
a/clang-tools-extra/test/clang-tidy/checkers/readability/use-numeric-limits.cpp
+++
b/clang-tools-extra/test/clang-tidy/checkers/readability/use-numeric-limits.cpp
@@ -2,83 +2,83 @@
#include <stdint.h>
void Invalid() {
- // CHECK-MESSAGES: :[[@LINE+2]]:14: warning: The constant -128 is being
utilized. Consider using std::numeric_limits<int8_t>::min() instead
[readability-use-numeric-limits]
+ // CHECK-MESSAGES: :[[@LINE+2]]:14: warning: the constant '-128' is being
utilized; consider using 'std::numeric_limits<int8_t>::min()' instead
[readability-use-numeric-limits]
// CHECK-FIXES: int8_t a = std::numeric_limits<int8_t>::min();
int8_t a = -128;
- // CHECK-MESSAGES: :[[@LINE+2]]:14: warning: The constant 127 is being
utilized. Consider using std::numeric_limits<int8_t>::max() instead
[readability-use-numeric-limits]
+ // CHECK-MESSAGES: :[[@LINE+2]]:14: warning: the constant '127' is being
utilized; consider using 'std::numeric_limits<int8_t>::max()' instead
[readability-use-numeric-limits]
// CHECK-FIXES: int8_t b = std::numeric_limits<int8_t>::max();
int8_t b = +127;
- // CHECK-MESSAGES: :[[@LINE+2]]:14: warning: The constant 127 is being
utilized. Consider using std::numeric_limits<int8_t>::max() instead
[readability-use-numeric-limits]
+ // CHECK-MESSAGES: :[[@LINE+2]]:14: warning: the constant '127' is being
utilized; consider using 'std::numeric_limits<int8_t>::max()' instead
[readability-use-numeric-limits]
// CHECK-FIXES: int8_t c = std::numeric_limits<int8_t>::max();
int8_t c = 127;
- // CHECK-MESSAGES: :[[@LINE+2]]:15: warning: The constant -32768 is being
utilized. Consider using std::numeric_limits<int16_t>::min() instead
[readability-use-numeric-limits]
+ // CHECK-MESSAGES: :[[@LINE+2]]:15: warning: the constant '-32768' is being
utilized; consider using 'std::numeric_limits<int16_t>::min()' instead
[readability-use-numeric-limits]
// CHECK-FIXES: int16_t d = std::numeric_limits<int16_t>::min();
int16_t d = -32768;
- // CHECK-MESSAGES: :[[@LINE+2]]:15: warning: The constant 32767 is being
utilized. Consider using std::numeric_limits<int16_t>::max() instead
[readability-use-numeric-limits]
+ // CHECK-MESSAGES: :[[@LINE+2]]:15: warning: the constant '32767' is being
utilized; consider using 'std::numeric_limits<int16_t>::max()' instead
[readability-use-numeric-limits]
// CHECK-FIXES: int16_t e = std::numeric_limits<int16_t>::max();
int16_t e = +32767;
- // CHECK-MESSAGES: :[[@LINE+2]]:15: warning: The constant 32767 is being
utilized. Consider using std::numeric_limits<int16_t>::max() instead
[readability-use-numeric-limits]
+ // CHECK-MESSAGES: :[[@LINE+2]]:15: warning: the constant '32767' is being
utilized; consider using 'std::numeric_limits<int16_t>::max()' instead
[readability-use-numeric-limits]
// CHECK-FIXES: int16_t f = std::numeric_limits<int16_t>::max();
int16_t f = 32767;
- // CHECK-MESSAGES: :[[@LINE+2]]:15: warning: The constant -2147483648 is
being utilized. Consider using std::numeric_limits<int32_t>::min() instead
[readability-use-numeric-limits]
+ // CHECK-MESSAGES: :[[@LINE+2]]:15: warning: the constant '-2147483648' is
being utilized; consider using 'std::numeric_limits<int32_t>::min()' instead
[readability-use-numeric-limits]
// CHECK-FIXES: int32_t g = std::numeric_limits<int32_t>::min();
int32_t g = -2147483648;
- // CHECK-MESSAGES: :[[@LINE+2]]:15: warning: The constant 2147483647 is
being utilized. Consider using std::numeric_limits<int32_t>::max() instead
[readability-use-numeric-limits]
+ // CHECK-MESSAGES: :[[@LINE+2]]:15: warning: the constant '2147483647' is
being utilized; consider using 'std::numeric_limits<int32_t>::max()' instead
[readability-use-numeric-limits]
// CHECK-FIXES: int32_t h = std::numeric_limits<int32_t>::max();
int32_t h = +2147483647;
- // CHECK-MESSAGES: :[[@LINE+2]]:15: warning: The constant 2147483647 is
being utilized. Consider using std::numeric_limits<int32_t>::max() instead
[readability-use-numeric-limits]
+ // CHECK-MESSAGES: :[[@LINE+2]]:15: warning: the constant '2147483647' is
being utilized; consider using 'std::numeric_limits<int32_t>::max()' instead
[readability-use-numeric-limits]
// CHECK-FIXES: int32_t i = std::numeric_limits<int32_t>::max();
int32_t i = 2147483647;
- // CHECK-MESSAGES: :[[@LINE+2]]:15: warning: The constant
-9223372036854775808 is being utilized. Consider using
std::numeric_limits<int64_t>::min() instead [readability-use-numeric-limits]
+ // CHECK-MESSAGES: :[[@LINE+2]]:15: warning: the constant
'-9223372036854775808' is being utilized; consider using
'std::numeric_limits<int64_t>::min()' instead [readability-use-numeric-limits]
// CHECK-FIXES: int64_t j = std::numeric_limits<int64_t>::min();
int64_t j = -9223372036854775808;
- // CHECK-MESSAGES: :[[@LINE+2]]:15: warning: The constant
9223372036854775807 is being utilized. Consider using
std::numeric_limits<int64_t>::max() instead [readability-use-numeric-limits]
+ // CHECK-MESSAGES: :[[@LINE+2]]:15: warning: the constant
'9223372036854775807' is being utilized; consider using
'std::numeric_limits<int64_t>::max()' instead [readability-use-numeric-limits]
// CHECK-FIXES: int64_t k = std::numeric_limits<int64_t>::max();
int64_t k = +9223372036854775807;
- // CHECK-MESSAGES: :[[@LINE+2]]:15: warning: The constant
9223372036854775807 is being utilized. Consider using
std::numeric_limits<int64_t>::max() instead [readability-use-numeric-limits]
+ // CHECK-MESSAGES: :[[@LINE+2]]:15: warning: the constant
'9223372036854775807' is being utilized; consider using
'std::numeric_limits<int64_t>::max()' instead [readability-use-numeric-limits]
// CHECK-FIXES: int64_t l = std::numeric_limits<int64_t>::max();
int64_t l = 9223372036854775807;
- // CHECK-MESSAGES: :[[@LINE+2]]:15: warning: The constant 255 is being
utilized. Consider using std::numeric_limits<uint8_t>::max() instead
[readability-use-numeric-limits]
+ // CHECK-MESSAGES: :[[@LINE+2]]:15: warning: the constant '255' is being
utilized; consider using 'std::numeric_limits<uint8_t>::max()' instead
[readability-use-numeric-limits]
// CHECK-FIXES: uint8_t m = std::numeric_limits<uint8_t>::max();
uint8_t m = 255;
- // CHECK-MESSAGES: :[[@LINE+2]]:15: warning: The constant 255 is being
utilized. Consider using std::numeric_limits<uint8_t>::max() instead
[readability-use-numeric-limits]
+ // CHECK-MESSAGES: :[[@LINE+2]]:15: warning: the constant '255' is being
utilized; consider using 'std::numeric_limits<uint8_t>::max()' instead
[readability-use-numeric-limits]
// CHECK-FIXES: uint8_t n = std::numeric_limits<uint8_t>::max();
uint8_t n = +255;
- // CHECK-MESSAGES: :[[@LINE+2]]:16: warning: The constant 65535 is being
utilized. Consider using std::numeric_limits<uint16_t>::max() instead
[readability-use-numeric-limits]
+ // CHECK-MESSAGES: :[[@LINE+2]]:16: warning: the constant '65535' is being
utilized; consider using 'std::numeric_limits<uint16_t>::max()' instead
[readability-use-numeric-limits]
// CHECK-FIXES: uint16_t o = std::numeric_limits<uint16_t>::max();
uint16_t o = 65535;
- // CHECK-MESSAGES: :[[@LINE+2]]:16: warning: The constant 65535 is being
utilized. Consider using std::numeric_limits<uint16_t>::max() instead
[readability-use-numeric-limits]
+ // CHECK-MESSAGES: :[[@LINE+2]]:16: warning: the constant '65535' is being
utilized; consider using 'std::numeric_limits<uint16_t>::max()' instead
[readability-use-numeric-limits]
// CHECK-FIXES: uint16_t p = std::numeric_limits<uint16_t>::max();
uint16_t p = +65535;
- // CHECK-MESSAGES: :[[@LINE+2]]:16: warning: The constant 4294967295 is
being utilized. Consider using std::numeric_limits<uint32_t>::max() instead
[readability-use-numeric-limits]
+ // CHECK-MESSAGES: :[[@LINE+2]]:16: warning: the constant '4294967295' is
being utilized; consider using 'std::numeric_limits<uint32_t>::max()' instead
[readability-use-numeric-limits]
// CHECK-FIXES: uint32_t q = std::numeric_limits<uint32_t>::max();
uint32_t q = 4294967295;
- // CHECK-MESSAGES: :[[@LINE+2]]:16: warning: The constant 4294967295 is
being utilized. Consider using std::numeric_limits<uint32_t>::max() instead
[readability-use-numeric-limits]
+ // CHECK-MESSAGES: :[[@LINE+2]]:16: warning: the constant '4294967295' is
being utilized; consider using 'std::numeric_limits<uint32_t>::max()' instead
[readability-use-numeric-limits]
// CHECK-FIXES: uint32_t r = std::numeric_limits<uint32_t>::max();
uint32_t r = +4294967295;
- // CHECK-MESSAGES: :[[@LINE+2]]:16: warning: The constant
18446744073709551615 is being utilized. Consider using
std::numeric_limits<uint64_t>::max() instead [readability-use-numeric-limits]
+ // CHECK-MESSAGES: :[[@LINE+2]]:16: warning: the constant
'18446744073709551615' is being utilized; consider using
'std::numeric_limits<uint64_t>::max()' instead [readability-use-numeric-limits]
// CHECK-FIXES: uint64_t s = std::numeric_limits<uint64_t>::max();
uint64_t s = 18446744073709551615;
- // CHECK-MESSAGES: :[[@LINE+2]]:16: warning: The constant
18446744073709551615 is being utilized. Consider using
std::numeric_limits<uint64_t>::max() instead [readability-use-numeric-limits]
+ // CHECK-MESSAGES: :[[@LINE+2]]:16: warning: the constant
'18446744073709551615' is being utilized; consider using
'std::numeric_limits<uint64_t>::max()' instead [readability-use-numeric-limits]
// CHECK-FIXES: uint64_t t = std::numeric_limits<uint64_t>::max();
uint64_t t = +18446744073709551615;
}
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
