================
@@ -1621,6 +1621,13 @@ def DeviceKernel : DeclOrTypeAttr {
 }];
 }
 
+def SYCLExternal : InheritableAttr {
+  let Spellings = [Clang<"sycl_external">];
+  let Subjects = SubjectList<[Function]>;
----------------
tahonermann wrote:

Error diagnostics are explicitly requested for many other attributes including 
`sycl_kernel_entry_point`. I think the default is to emit a warning if an 
attribute is used with an entity for which it does not appertain; we should be 
consistent.
```suggestion
  let Subjects = SubjectList<[Function], ErrorDiag>;
```

https://github.com/llvm/llvm-project/pull/140282
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to