================ @@ -0,0 +1,239 @@ +//===--- BoolBitwiseOperationCheck.cpp - clang-tidy -----------------------===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +#include "BoolBitwiseOperationCheck.h" +#include "clang/ASTMatchers/ASTMatchFinder.h" +#include "clang/Lex/Lexer.h" +#include "llvm/ADT/ScopeExit.h" +#include "llvm/ADT/Twine.h" +#include <array> +#include <optional> +#include <utility> + +using namespace clang::ast_matchers; + +namespace clang::tidy::performance { + +static std::string tryPrintVariable(const BinaryOperator *BO) { + if (BO->isCompoundAssignmentOp()) { + const auto *DelcRefLHS = + dyn_cast<DeclRefExpr>(BO->getLHS()->IgnoreImpCasts()); + if (DelcRefLHS) + return ("variable '" + + llvm::Twine(DelcRefLHS->getDecl()->getNameAsString()) + "'") + .str(); + } + return "values"; +} + +static bool hasExplicitParentheses(const Expr *E, const SourceManager &SM, + const LangOptions &LangOpts) { + if (!E) + return false; + + const SourceLocation Start = E->getBeginLoc(); + const SourceLocation End = E->getEndLoc(); + + if (Start.isMacroID() || End.isMacroID() || Start.isInvalid() || + End.isInvalid()) + return false; + + const std::optional<Token> PrevTok = + Lexer::findPreviousToken(Start, SM, LangOpts, /*IncludeComments=*/false); + const std::optional<Token> NextTok = + Lexer::findNextToken(End, SM, LangOpts, /*IncludeComments=*/false); + + return (PrevTok && PrevTok->is(tok::l_paren)) && + (NextTok && NextTok->is(tok::r_paren)); +} + +template <typename AstNode> +static bool isInTemplateFunction(const AstNode *AN, ASTContext &Context) { + DynTypedNodeList Parents = Context.getParents(*AN); + for (const DynTypedNode &Parent : Parents) { + if (const auto *FD = Parent.template get<FunctionDecl>()) + return FD->isTemplateInstantiation() || + FD->getTemplatedKind() != FunctionDecl::TK_NonTemplate; + if (const auto *S = Parent.template get<Stmt>()) + return isInTemplateFunction(S, Context); + } + return false; +} + +constexpr std::array<std::pair<llvm::StringRef, llvm::StringRef>, 8U> + OperatorsTransformation{{{"|", "||"}, + {"|=", "||"}, + {"&", "&&"}, + {"&=", "&&"}, + {"bitand", "and"}, + {"and_eq", "and"}, + {"bitor", "or"}, + {"or_eq", "or"}}}; + +static std::string translate(llvm::StringRef Value) { + for (const auto &[Bitwise, Logical] : OperatorsTransformation) { + if (Value == Bitwise) + return Logical.str(); + } + + return {}; +} + +BoolBitwiseOperationCheck::BoolBitwiseOperationCheck(StringRef Name, + ClangTidyContext *Context) + : ClangTidyCheck(Name, Context), + StrictMode(Options.get("StrictMode", true)), + IgnoreMacros(Options.get("IgnoreMacros", false)) {} + +void BoolBitwiseOperationCheck::storeOptions( + ClangTidyOptions::OptionMap &Opts) { + Options.store(Opts, "StrictMode", StrictMode); + Options.store(Opts, "IgnoreMacros", IgnoreMacros); +} + +void BoolBitwiseOperationCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher( + binaryOperator( + unless(isExpansionInSystemHeader()), + hasAnyOperatorName("|", "&", "|=", "&="), + hasEitherOperand(expr(ignoringImpCasts(hasType(booleanType())))), + optionally(hasAncestor( // to simple implement transformations like + // `a&&b|c` -> `a&&(b||c)` + binaryOperator().bind("p")))) + .bind("op"), + this); +} + +void BoolBitwiseOperationCheck::check(const MatchFinder::MatchResult &Result) { + const auto *MatchedExpr = Result.Nodes.getNodeAs<BinaryOperator>("op"); + + auto DiagEmitterProc = [MatchedExpr, this] { + return diag(MatchedExpr->getOperatorLoc(), + "use logical operator '%0' for boolean %1 instead of " + "bitwise operator '%2'") + << translate(MatchedExpr->getOpcodeStr()) + << tryPrintVariable(MatchedExpr) << MatchedExpr->getOpcodeStr(); + }; + auto DiagEmitter = llvm::make_scope_exit(DiagEmitterProc); + + if (isInTemplateFunction(MatchedExpr, *Result.Context)) + return; + + const bool HasVolatileOperand = llvm::any_of( + std::array{MatchedExpr->getLHS(), MatchedExpr->getRHS()}, + [](const Expr *E) { + return E->IgnoreImpCasts()->getType().isVolatileQualified(); + }); + const bool HasSideEffects = + MatchedExpr->getRHS()->HasSideEffects(*Result.Context, StrictMode); + if (HasVolatileOperand || HasSideEffects) + return; ---------------- PiotrZSL wrote:
split into 2 ifs https://github.com/llvm/llvm-project/pull/142324 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
