RKSimon added a comment. Test _mm256_cmp_pd as well?
================ Comment at: lib/CodeGen/CGBuiltin.cpp:7922 case X86::BI__builtin_ia32_cmpps256: + if (CC == 0xf) { + Value *Vec = Builder.CreateVectorSplat(Ops[0]->getType()->getVectorNumElements(), ---------------- You need a comment here - explain what the constant represents and what the transform does. ================ Comment at: test/CodeGen/avx-builtins.c:1434 + // CHECK: store <8 x float> <float 0xFFFFFFFFE0000000, + return _mm256_cmp_ps(a, b, 0xf); +} ---------------- Use _CMP_TRUE_UQ here instead of 0xf? https://reviews.llvm.org/D33406 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits