llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang-driver Author: Garvit Gupta (quic-garvgupt) <details> <summary>Changes</summary> Fuchsia sets CLANG_DEFAULT_UNWINDLIB to libunwind. As a result, when rtlib is set to libgcc and unwindlib is not explicitly specified, tests using Fuchsia as the default platform will fail. To address this, the affected tests are now marked as unsupported on the Fuchsia platform. This change fixes the following tests introduced in https://github.com/llvm/llvm-project/commit/45ea46c44636094e9fcdbbeabfd11f9d0fad5e38: clang/test/Driver/aarch64-toolchain-extra.c clang/test/Driver/arm-toolchain-extra.c clang/test/Driver/aarch64-toolchain.c clang/test/Driver/arm-toolchain.c --- Full diff: https://github.com/llvm/llvm-project/pull/144655.diff 4 Files Affected: - (modified) clang/test/Driver/aarch64-toolchain-extra.c (+1-1) - (modified) clang/test/Driver/aarch64-toolchain.c (+1-1) - (modified) clang/test/Driver/arm-toolchain-extra.c (+1-1) - (modified) clang/test/Driver/arm-toolchain.c (+1-1) ``````````diff diff --git a/clang/test/Driver/aarch64-toolchain-extra.c b/clang/test/Driver/aarch64-toolchain-extra.c index 2610e962bd690..d8ba0556167ab 100644 --- a/clang/test/Driver/aarch64-toolchain-extra.c +++ b/clang/test/Driver/aarch64-toolchain-extra.c @@ -4,7 +4,7 @@ // these tests need to create symlinks to test directory trees in order to // set up the environment and therefore shell support is required. // REQUIRES: shell -// UNSUPPORTED: system-windows +// UNSUPPORTED: system-windows, target={{.*}}-fuchsia{{.*}} // If there is no GCC install detected then the driver searches for executables // and runtime starting from the directory tree above the driver itself. diff --git a/clang/test/Driver/aarch64-toolchain.c b/clang/test/Driver/aarch64-toolchain.c index 7f2c01d928e43..dfa63bfff4d1c 100644 --- a/clang/test/Driver/aarch64-toolchain.c +++ b/clang/test/Driver/aarch64-toolchain.c @@ -1,4 +1,4 @@ -// UNSUPPORTED: system-windows +// UNSUPPORTED: system-windows, target={{.*}}-fuchsia{{.*}} // RUN: %clang -### %s -fuse-ld= \ // RUN: --target=aarch64-none-elf --rtlib=libgcc \ diff --git a/clang/test/Driver/arm-toolchain-extra.c b/clang/test/Driver/arm-toolchain-extra.c index 114de0a8154ab..f3e4f5f368d38 100644 --- a/clang/test/Driver/arm-toolchain-extra.c +++ b/clang/test/Driver/arm-toolchain-extra.c @@ -4,7 +4,7 @@ // these tests need to create symlinks to test directory trees in order to // set up the environment and therefore shell support is required. // REQUIRES: shell -// UNSUPPORTED: system-windows +// UNSUPPORTED: system-windows, target={{.*}}-fuchsia{{.*}} // If there is no GCC install detected then the driver searches for executables // and runtime starting from the directory tree above the driver itself. diff --git a/clang/test/Driver/arm-toolchain.c b/clang/test/Driver/arm-toolchain.c index 2e38461fb7a3e..8cd6c5e96b7a0 100644 --- a/clang/test/Driver/arm-toolchain.c +++ b/clang/test/Driver/arm-toolchain.c @@ -1,4 +1,4 @@ -// UNSUPPORTED: system-windows +// UNSUPPORTED: system-windows, target={{.*}}-fuchsia{{.*}} // RUN: %clang -### %s -fuse-ld= \ // RUN: --target=armv6m-none-eabi --rtlib=libgcc \ `````````` </details> https://github.com/llvm/llvm-project/pull/144655 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
