arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.

LGTM with one change below:



================
Comment at: lib/Sema/SemaDeclAttr.cpp:7256
+  bool VisitObjCPropertyRefExpr(ObjCPropertyRefExpr *PRE) {
+    if (ObjCInterfaceDecl *ID = PRE->getClassReceiver())
+      DiagnoseDeclAvailability(ID, PRE->getReceiverLocation());
----------------
`getClassReceiver` calls `get` in a PointerUnion, which will trigger an 
assertion when the PRE is not a class receiver. Please rewrite this `if` to 
something like:

```
    if (PRE->isClassReceiver())
      DiagnoseDeclAvailability(PRE->getClassReceiver(), 
PRE->getReceiverLocation());
```



https://reviews.llvm.org/D33250



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to