================
@@ -227,26 +227,24 @@ class CIRBaseBuilderTy : public mlir::OpBuilder {
   
//===--------------------------------------------------------------------===//
 
   cir::CallOp createCallOp(mlir::Location loc, mlir::SymbolRefAttr callee,
-                           mlir::Type returnType, mlir::ValueRange operands,
-                           cir::SideEffect sideEffect = cir::SideEffect::All) {
----------------
bcardosolopes wrote:

Have you thought about just having a `ArrayRef<Attribute> attrs = {}`? This 
would allow the caller to already pass stuff in if available.

https://github.com/llvm/llvm-project/pull/145178
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to