martell added a comment. LGTM but I can't speak for the area where you added `#include <cstdio>` and killed off the `_NEWLIB_VERSION` check Seems in order based on https://sourceware.org/ml/newlib-cvs/2014-q3/msg00038.html Maybe make a note of the minimum newlib version supported somewhere?
Others may have more specific thoughts on the diff. https://reviews.llvm.org/D33082 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
