llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) <details> <summary>Changes</summary> NumElts, a member variable of ArrayTypeInfo, is already of Expr *. --- Full diff: https://github.com/llvm/llvm-project/pull/148338.diff 2 Files Affected: - (modified) clang/lib/Sema/SemaExprCXX.cpp (+2-2) - (modified) clang/lib/Sema/SemaType.cpp (+1-1) ``````````diff diff --git a/clang/lib/Sema/SemaExprCXX.cpp b/clang/lib/Sema/SemaExprCXX.cpp index f17a338825423..5dca34c04a71b 100644 --- a/clang/lib/Sema/SemaExprCXX.cpp +++ b/clang/lib/Sema/SemaExprCXX.cpp @@ -2021,7 +2021,7 @@ Sema::ActOnCXXNew(SourceLocation StartLoc, bool UseGlobal, return ExprError(Diag(Chunk.Loc, diag::err_array_new_needs_size) << D.getSourceRange()); - ArraySize = static_cast<Expr*>(Chunk.Arr.NumElts); + ArraySize = Chunk.Arr.NumElts; D.DropFirstTypeObject(); } @@ -2032,7 +2032,7 @@ Sema::ActOnCXXNew(SourceLocation StartLoc, bool UseGlobal, break; DeclaratorChunk::ArrayTypeInfo &Array = D.getTypeObject(I).Arr; - if (Expr *NumElts = (Expr *)Array.NumElts) { + if (Expr *NumElts = Array.NumElts) { if (!NumElts->isTypeDependent() && !NumElts->isValueDependent()) { // FIXME: GCC permits constant folding here. We should either do so consistently // or not do so at all, rather than changing behavior in C++14 onwards. diff --git a/clang/lib/Sema/SemaType.cpp b/clang/lib/Sema/SemaType.cpp index 88aa63d3b9e83..661746731fdcc 100644 --- a/clang/lib/Sema/SemaType.cpp +++ b/clang/lib/Sema/SemaType.cpp @@ -4727,7 +4727,7 @@ static TypeSourceInfo *GetFullTypeForDeclarator(TypeProcessingState &state, // Build the type anyway. } DeclaratorChunk::ArrayTypeInfo &ATI = DeclType.Arr; - Expr *ArraySize = static_cast<Expr*>(ATI.NumElts); + Expr *ArraySize = ATI.NumElts; ArraySizeModifier ASM; // Microsoft property fields can have multiple sizeless array chunks `````````` </details> https://github.com/llvm/llvm-project/pull/148338 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
