alexfh added a comment. In https://reviews.llvm.org/D33304#768961, @yawanng wrote:
> In https://reviews.llvm.org/D33304#768731, @alexfh wrote: > > > It's awesome to see another two checks, and it seems to justify adding a > > separate module, but I'd prefer the other two checks to be sent for review > > as separate patches to make the review easier and faster. > > > The other two checks are relatively small and simple. I understand this may > make the review process longer and we could wait for that. Please take your > time :-) Thank you! It's not only longer to review larger patches, it's also less convenient for the reviewers. Please send each check as a separate patch (the addition of the module can be in one of them). Phabricator has decent support for dependent patches, so it shouldn't add much work on your side. https://reviews.llvm.org/D33304 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
