echristo added inline comments.
================
Comment at: include/clang/Basic/Attr.td:1790-1794
+ // target features respectively.
+ if (Feature.compare("arm") == 0)
+ Ret.first.push_back("-thumb-mode");
+ else if (Feature.compare("thumb") == 0)
+ Ret.first.push_back("+thumb-mode");
----------------
This is a little painful here - I wonder if we have access to TargetInfo or
maybe translate it in the target specific area of the front end? I worry about
this sort of thing getting unwieldy.
Thoughts?
Otherwise OK.
https://reviews.llvm.org/D33721
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
