rjmccall added inline comments.

================
Comment at: test/CodeGenCXX/strict-vtable-pointers.cpp:263
+
+struct VirtualInVBase : virtual Empty, HoldingVirtuals {
+};
----------------
"virtual" applies to an individual base, not to all following bases.  You need 
"virtual HoldingVirtuals" here.

Although, come to think of it, having a virtual base should already ensure that 
the class has a v-table, even if it has no other reason for one.  (You should 
add a test for that!)


https://reviews.llvm.org/D31830



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to