rjmccall added inline comments.
================
Comment at: include/clang/AST/Decl.h:1388
SourceLocation IdLoc, IdentifierInfo *Id,
- QualType T);
+ QualType T, bool IsThisOrSelf = false);
----------------
Is there a good reason not to have a little enum here and require the caller to
pass it down? There's only 20 different call sites, it shouldn't be hard to
quickly classify them.
I think we should at least have:
ObjCSelf
ObjCCmd
CXXThis
CXXVTT
and then if you want to categorize everything else as Other, that's fine.
================
Comment at: lib/CodeGen/CGDebugInfo.cpp:3466
+ // If this is the first argument, it is implicit and has ThisOrSelf attribute
+ // then give it an object pointer flag.
+ if (ArgNo && *ArgNo == 1)
----------------
I don't think you need the ArgNo conditions anymore.
https://reviews.llvm.org/D33735
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
