[PATCH] D33827: [clang-tidy] misc-static-assert shouldn't flag assert(!"msg")

[Florian Gross via Phabricator via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL304657: [clang-tidy] Make misc-static-assert accept 
assert(!"msg") (authored by fgross).

Changed prior to commit:
  https://reviews.llvm.org/D33827?vs=101197&id=101311#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D33827

Files:
  clang-tools-extra/trunk/clang-tidy/misc/StaticAssertCheck.cpp
  clang-tools-extra/trunk/test/clang-tidy/misc-static-assert.cpp


Index: clang-tools-extra/trunk/test/clang-tidy/misc-static-assert.cpp
===================================================================
--- clang-tools-extra/trunk/test/clang-tidy/misc-static-assert.cpp
+++ clang-tools-extra/trunk/test/clang-tidy/misc-static-assert.cpp
@@ -76,6 +76,9 @@
   // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: found assert() that could be
   // CHECK-FIXES: {{^  }}static_assert(ZERO_MACRO, "");
 
+  assert(!"Don't report me!");
+  // CHECK-FIXES: {{^  }}assert(!"Don't report me!");
+
   assert(0 && "Don't report me!");
   // CHECK-FIXES: {{^  }}assert(0 && "Don't report me!");
 
Index: clang-tools-extra/trunk/clang-tidy/misc/StaticAssertCheck.cpp
===================================================================
--- clang-tools-extra/trunk/clang-tidy/misc/StaticAssertCheck.cpp
+++ clang-tools-extra/trunk/clang-tidy/misc/StaticAssertCheck.cpp
@@ -33,9 +33,11 @@
   if (!(getLangOpts().CPlusPlus11 || getLangOpts().C11))
     return;
 
+  auto NegatedString = unaryOperator(
+      hasOperatorName("!"), 
hasUnaryOperand(ignoringImpCasts(stringLiteral())));
   auto IsAlwaysFalse =
       expr(anyOf(cxxBoolLiteral(equals(false)), integerLiteral(equals(0)),
-                 cxxNullPtrLiteralExpr(), gnuNullExpr()))
+                 cxxNullPtrLiteralExpr(), gnuNullExpr(), NegatedString))
           .bind("isAlwaysFalse");
   auto IsAlwaysFalseWithCast = ignoringParenImpCasts(anyOf(
       IsAlwaysFalse, cStyleCastExpr(has(ignoringParenImpCasts(IsAlwaysFalse)))



Index: clang-tools-extra/trunk/test/clang-tidy/misc-static-assert.cpp
===================================================================
--- clang-tools-extra/trunk/test/clang-tidy/misc-static-assert.cpp
+++ clang-tools-extra/trunk/test/clang-tidy/misc-static-assert.cpp
@@ -76,6 +76,9 @@
   // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: found assert() that could be
   // CHECK-FIXES: {{^  }}static_assert(ZERO_MACRO, "");
 
+  assert(!"Don't report me!");
+  // CHECK-FIXES: {{^  }}assert(!"Don't report me!");
+
   assert(0 && "Don't report me!");
   // CHECK-FIXES: {{^  }}assert(0 && "Don't report me!");
 
Index: clang-tools-extra/trunk/clang-tidy/misc/StaticAssertCheck.cpp
===================================================================
--- clang-tools-extra/trunk/clang-tidy/misc/StaticAssertCheck.cpp
+++ clang-tools-extra/trunk/clang-tidy/misc/StaticAssertCheck.cpp
@@ -33,9 +33,11 @@
   if (!(getLangOpts().CPlusPlus11 || getLangOpts().C11))
     return;
 
+  auto NegatedString = unaryOperator(
+      hasOperatorName("!"), hasUnaryOperand(ignoringImpCasts(stringLiteral())));
   auto IsAlwaysFalse =
       expr(anyOf(cxxBoolLiteral(equals(false)), integerLiteral(equals(0)),
-                 cxxNullPtrLiteralExpr(), gnuNullExpr()))
+                 cxxNullPtrLiteralExpr(), gnuNullExpr(), NegatedString))
           .bind("isAlwaysFalse");
   auto IsAlwaysFalseWithCast = ignoringParenImpCasts(anyOf(
       IsAlwaysFalse, cStyleCastExpr(has(ignoringParenImpCasts(IsAlwaysFalse)))

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits