================
@@ -48,6 +48,7 @@
// instantiation for v<int> in one of the two headers, because we will only
// parse one of the two get() functions.
+#ifdef NS
----------------
jmmartinez wrote:
We do not need the change in the test anymore. In the test the macro expansion
is done on a preprocessor directive which are expanded. A first version of this
patch didn't allow macro expansion on preprocessor directives so the test
failed.
When we execute the test, in `CompilerInstance::createModuleFromSource` we
create a module map that is marked as preprocessed, and where the contents are:
```cpp
module m {
module a {
header "foo.h" { size 123 mtime 456789 }
}
module b {}
}
#pragma clang module contents
#pragma clang module begin m.a
inline int non_trivial() { return 3; }
#ifdef NS
namespace ns {
#endif
/* ... more code ... */
#ifdef NS
}
#endif
#pragma clang module end
```
If we did not preprocessed the directives the test failed.
In any case, I've removed the change from this patch and after you confirm this
is is ok now, I'll merge the changes.
Thanks a lot for the reviews !
https://github.com/llvm/llvm-project/pull/137665
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
