================
@@ -1388,9 +1393,170 @@ static std::string formatOffset(uint64_t OffsetInBits) {
   return Offset;
 }
 
-markup::Document HoverInfo::present() const {
+markup::Document HoverInfo::presentDoxygen() const {
+  // NOTE: this function is currently almost identical to presentDefault().
----------------
emaxx-google wrote:

There's a lot of code that's duplicated here - this might eventually lead to 
subtle divergence between two branches and bugs. How big are the 
doxygen-specific bits going to be, and would it be possible to fit them into a 
single common implementation (maybe with a help of helper functions)?

https://github.com/llvm/llvm-project/pull/150790
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to