rjmccall added inline comments.

================
Comment at: lib/Sema/SemaTemplate.cpp:8985
+        // FIXME:  Would this be considered an almost match as well?
+        continue;
       }
----------------
These continues that you're adding are already at the end of the loop body, so 
this code is really confusing.

I think the template-specialization check here is trying to do the same thing 
you're doing: treat non-template matches specially.  But your way of handling 
it is better, so I would just remove the check and all the breaks and continues 
so that we add the match to either NonTemplateMatch or TemplateMatches.  
(Please do rename Matches to TemplateMatches, though.)


https://reviews.llvm.org/D17215



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to