Author: alexfh Date: Fri Jun 9 02:34:58 2017 New Revision: 305057 URL: http://llvm.org/viewvc/llvm-project?rev=305057&view=rev Log: Revert "[clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed."
This reverts commit r304949. https://reviews.llvm.org/D34002#775830 Modified: clang-tools-extra/trunk/clang-tidy/misc/NoexceptMoveConstructorCheck.cpp clang-tools-extra/trunk/test/clang-tidy/misc-noexcept-move-constructor.cpp Modified: clang-tools-extra/trunk/clang-tidy/misc/NoexceptMoveConstructorCheck.cpp URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/misc/NoexceptMoveConstructorCheck.cpp?rev=305057&r1=305056&r2=305057&view=diff ============================================================================== --- clang-tools-extra/trunk/clang-tidy/misc/NoexceptMoveConstructorCheck.cpp (original) +++ clang-tools-extra/trunk/clang-tidy/misc/NoexceptMoveConstructorCheck.cpp Fri Jun 9 02:34:58 2017 @@ -20,7 +20,7 @@ namespace misc { void NoexceptMoveConstructorCheck::registerMatchers(MatchFinder *Finder) { // Only register the matchers for C++11; the functionality currently does not // provide any benefit to other languages, despite being benign. - if (!getLangOpts().CPlusPlus11 || !getLangOpts().CXXExceptions) + if (!getLangOpts().CPlusPlus11) return; Finder->addMatcher( Modified: clang-tools-extra/trunk/test/clang-tidy/misc-noexcept-move-constructor.cpp URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/misc-noexcept-move-constructor.cpp?rev=305057&r1=305056&r2=305057&view=diff ============================================================================== --- clang-tools-extra/trunk/test/clang-tidy/misc-noexcept-move-constructor.cpp (original) +++ clang-tools-extra/trunk/test/clang-tidy/misc-noexcept-move-constructor.cpp Fri Jun 9 02:34:58 2017 @@ -1,25 +1,16 @@ -// RUN: clang-tidy %s -checks="-*,misc-noexcept-move-constructor" -- -std=c++11 \ -// RUN: | FileCheck %s -check-prefix=CHECK-EXCEPTIONS \ -// RUN: -implicit-check-not="{{warning|error}}:" -// RUN: clang-tidy %s -checks="-*,misc-noexcept-move-constructor" -- -fno-exceptions -std=c++11 \ -// RUN: | FileCheck %s -allow-empty -check-prefix=CHECK-NONEXCEPTIONS \ -// RUN: -implicit-check-not="{{warning|error}}:" - +// RUN: %check_clang_tidy %s misc-noexcept-move-constructor %t class A { A(A &&); - // CHECK-EXCEPTIONS: :[[@LINE-1]]:3: warning: move constructors should be marked noexcept [misc-noexcept-move-constructor] - // CHECK-NONEXCEPTIONS-NOT: warning: + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: move constructors should be marked noexcept [misc-noexcept-move-constructor] A &operator=(A &&); - // CHECK-EXCEPTIONS: :[[@LINE-1]]:6: warning: move assignment operators should - // CHECK-NONEXCEPTIONS-NOT: warning: + // CHECK-MESSAGES: :[[@LINE-1]]:6: warning: move assignment operators should }; struct B { static constexpr bool kFalse = false; B(B &&) noexcept(kFalse); - // CHECK-EXCEPTIONS: :[[@LINE-1]]:20: warning: noexcept specifier on the move constructor evaluates to 'false' [misc-noexcept-move-constructor] - // CHECK-NONEXCEPTIONS-NOT: warning: + // CHECK-MESSAGES: :[[@LINE-1]]:20: warning: noexcept specifier on the move constructor evaluates to 'false' [misc-noexcept-move-constructor] }; class OK {}; _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
