krasimir added inline comments.
================ Comment at: clangd/ClangdLSPServer.h:75 + LSPDiagnosticsConsumer DiagConsumer; + RealFileSystemProvider FSProvider; + ---------------- This approach is still inflexible. I'd make ClangdLSPServer : public DiagnosticsConsumer and pass references to the CompilationDatabase and to the FileSystemProvider to its constructor. I'd create these two in ClangdMain.cpp. https://reviews.llvm.org/D34148 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
