fedor.sergeev added inline comments.
================ Comment at: lib/Driver/ToolChains/Gnu.h:219-220 + void AddGnuIncludeArgs(const llvm::opt::ArgList &DriverArgs, + llvm::opt::ArgStringList &CC1Args) const; + ---------------- To me this does not belong to GCC-Installation-Detector at all, as it does not have anything to do with detection. As I see the only reason for adding it here is to check Version vs 4.8.0. If thats true then adding getVersion() here and using it elsewhere seems a better solution. https://reviews.llvm.org/D34158 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
