arphaman added inline comments.
================ Comment at: lib/Driver/ToolChains/Darwin.cpp:1133 + HadExtra) || + HadExtra || Major != 10 || Minor >= 100 || Micro >= 100) + return MacOSSDKVersion; ---------------- inouehrs wrote: > What these magic numbers mean (especially minor and micro versions)? > You may need some comments. I actually just took it from the function below which checks if the macOS version is valid (so we want 10.XX.XX). But looking at it again, I think that we don't really them here as the SDK version should will probably be valid. I'll update the patch and remove them from the code. Repository: rL LLVM https://reviews.llvm.org/D34175 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
