benlangmuir added a comment.
It would be nice if the doc comment for the single file parse mode flag was
updated to include this new functionality.
================
Comment at: lib/Lex/PPDirectives.cpp:2709
+ CurPPLexer->pushConditionalLevel(IfToken.getLocation(), /*wasskip*/true,
+ /*foundnonskip*/false, /*foundelse*/false);
+ } else if (ConditionalTrue) {
----------------
Nitpick: this is misaligned. Same with many other calls to
pushConditionalLevel in this patch.
================
Comment at: lib/Lex/PPDirectives.cpp:2774
+ // the directive blocks.
+ CurPPLexer->pushConditionalLevel(CI.IfLoc, /*wasskip*/false,
+ /*foundnonskip*/true, /*foundelse*/true);
----------------
Why is wasSkipping false here?
https://reviews.llvm.org/D34263
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
