[PATCH] D34249: [libc++] Don't use UTIME_OMIT to detect utimensat on Apple

[Marshall Clow via Phabricator via cfe-commits]

mclow.lists added inline comments.


================
Comment at: src/experimental/filesystem/operations.cpp:27
+// We can use the presence of UTIME_OMIT to detect platforms that do not
+// provide utimensat, with some exceptions on OS X.
+#if !defined(UTIME_OMIT) ||                                                    
\
----------------
Would it be easier to read if we split this test into two halves - one for 
Apple platforms and the other for the rest of the world?

    #if !defined(__APPLE__)
    # if !defined(UTIME_OMIT)
    # define _LIBCPP_HAS_NO_UTIMENSAT
    # endif
    #else
    .....
    #endif



https://reviews.llvm.org/D34249



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits