NoQ added a comment. In https://reviews.llvm.org/D34102#783161, @zaks.anna wrote:
> > eg. checkers for portability across linux/bsd should be off on windows by > > default, checkers for non-portable C++ APIs should be off in plain C code, > > etc > > Is the checker you are moving to portability off and not useful on Windows? It's the same as `MallocChecker`, as i explained above. A relevant code snippet from Driver.cpp: 2130 if (!IsWindowsMSVC) { 2131 CmdArgs.push_back("-analyzer-checker=unix"); 2132 } else { 2133 // Enable "unix" checkers that also work on Windows. 2134 CmdArgs.push_back("-analyzer-checker=unix.API"); 2135 CmdArgs.push_back("-analyzer-checker=unix.Malloc"); 2136 CmdArgs.push_back("-analyzer-checker=unix.MallocSizeof"); 2137 CmdArgs.push_back("-analyzer-checker=unix.MismatchedDeallocator"); 2138 CmdArgs.push_back("-analyzer-checker=unix.cstring.BadSizeArg"); 2139 CmdArgs.push_back("-analyzer-checker=unix.cstring.NullArg"); 2140 } My concern is not about this checker, it's about having to rename this checker if we decide that we need sub-packages for other portability checkers we may add in the future, which is totally realistic. https://reviews.llvm.org/D34102 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits