alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with one nit.
================
Comment at: clang-tidy/android/FileOpenFlagCheck.cpp:24
+
+bool HasCloseOnExecFlag(const Expr *Flags, const SourceManager &SM,
+ const LangOptions &LangOpts) {
----------------
nit: "Function names should be verb phrases (as they represent actions), and
command-like function should be imperative. The name should be camel case, and
start with a lower case letter (e.g. openFile() or isFoo())."
(http://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly)
https://reviews.llvm.org/D33304
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
