bd1976bris wrote:

> This change also appears to have broken our Windows builders:
> 
> ```
> Exit Code: 1
> 
> Command Output (stdout):
> --
> # RUN: at line 9
> c:\b\s\w\ir\x\w\llvm_build\bin\clang.exe -flto=thin 
> C:\b\s\w\ir\x\w\llvm-llvm-project\clang\test\Driver\DTLTO\dtlto.c -### 
> -fuse-ld=lld --target=x86_64-linux-gnu    -Xthinlto-distributor=a1 
> -Xthinlto-distributor=a2,a3    -fthinlto-distributor=d.exe -Werror 2>&1 |    
> c:\b\s\w\ir\x\w\llvm_build\bin\filecheck.exe 
> C:\b\s\w\ir\x\w\llvm-llvm-project\clang\test\Driver\DTLTO\dtlto.c 
> --check-prefix=FORWARD
> # executed command: 'c:\b\s\w\ir\x\w\llvm_build\bin\clang.exe' -flto=thin 
> 'C:\b\s\w\ir\x\w\llvm-llvm-project\clang\test\Driver\DTLTO\dtlto.c' '-###' 
> -fuse-ld=lld --target=x86_64-linux-gnu -Xthinlto-distributor=a1 
> -Xthinlto-distributor=a2,a3 -fthinlto-distributor=d.exe -Werror
> # executed command: 'c:\b\s\w\ir\x\w\llvm_build\bin\filecheck.exe' 
> 'C:\b\s\w\ir\x\w\llvm-llvm-project\clang\test\Driver\DTLTO\dtlto.c' 
> --check-prefix=FORWARD
> # .---command stderr------------
> # | C:\b\s\w\ir\x\w\llvm-llvm-project\clang\test\Driver\DTLTO\dtlto.c:17:18: 
> error: FORWARD-SAME: expected string not found in input
> # | // FORWARD-SAME: "--thinlto-distributor-arg=a1"
> # |                  ^
> # | <stdin>:7:787: note: scanning from here
> # |  "C:\\b\\s\\w\\ir\\x\\w\\llvm_build\\bin\\ld.lld" "--hash-style=gnu" 
> "--build-id" "--eh-frame-hdr" "-m" "elf_x86_64" "-pie" "-dynamic-linker" 
> "/lib64/ld-linux-x86-64.so.2" "-o" "a.out" "Scrt1.o" "crti.o" "crtbeginS.o" 
> "-plugin-opt=mcpu=x86-64" "-plugin-opt=thinlto" "--thinlto-distributor=d.exe" 
> "--thinlto-remote-compiler=C:\\b\\s\\w\\ir\\x\\w\\llvm_build\\bin\\clang.exe" 
> "--thinlto-distributor-arg=a1" "--thinlto-distributor-arg=a2" 
> "--thinlto-distributor-arg=a3" 
> "C:\\b\\s\\w\\ir\\x\\t\\lit-tmp-dw4aq672\\dtlto-029f91.o" 
> "C:\\b\\s\\w\\ir\\x\\w\\llvm_build\\lib\\clang\\22\\lib\\x86_64-unknown-linux-gnu\\libclang_rt.builtins.a"
>  "--as-needed" "-lunwind" "--no-as-needed" "-lc" 
> "C:\\b\\s\\w\\ir\\x\\w\\llvm_build\\lib\\clang\\22\\lib\\x86_64-unknown-linux-gnu\\libclang_rt.builtins.a"
>  "--as-needed" "-lunwind" "--no-as-needed" "crtendS.o" "crtn.o"
> # |                                                                           
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>           ^
> # | <stdin>:7:830: note: possible intended match here
> # |  "C:\\b\\s\\w\\ir\\x\\w\\llvm_build\\bin\\ld.lld" "--hash-style=gnu" 
> "--build-id" "--eh-frame-hdr" "-m" "elf_x86_64" "-pie" "-dynamic-linker" 
> "/lib64/ld-linux-x86-64.so.2" "-o" "a.out" "Scrt1.o" "crti.o" "crtbeginS.o" 
> "-plugin-opt=mcpu=x86-64" "-plugin-opt=thinlto" "--thinlto-distributor=d.exe" 
> "--thinlto-remote-compiler=C:\\b\\s\\w\\ir\\x\\w\\llvm_build\\bin\\clang.exe" 
> "--thinlto-distributor-arg=a1" "--thinlto-distributor-arg=a2" 
> "--thinlto-distributor-arg=a3" 
> "C:\\b\\s\\w\\ir\\x\\t\\lit-tmp-dw4aq672\\dtlto-029f91.o" 
> "C:\\b\\s\\w\\ir\\x\\w\\llvm_build\\lib\\clang\\22\\lib\\x86_64-unknown-linux-gnu\\libclang_rt.builtins.a"
>  "--as-needed" "-lunwind" "--no-as-needed" "-lc" 
> "C:\\b\\s\\w\\ir\\x\\w\\llvm_build\\lib\\clang\\22\\lib\\x86_64-unknown-linux-gnu\\libclang_rt.builtins.a"
>  "--as-needed" "-lunwind" "--no-as-needed" "crtendS.o" "crtn.o"
> # |                                                                           
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>                                                      ^
> # | 
> # | Input file: <stdin>
> # | Check file: 
> C:\b\s\w\ir\x\w\llvm-llvm-project\clang\test\Driver\DTLTO\dtlto.c
> # | 
> # | -dump-input=help explains the following input dump.
> # | 
> # | Input was:
> # | <<<<<<
> # |            1: Fuchsia clang version 22.0.0git 
> (https://llvm.googlesource.com/llvm-project 
> a3762fb2405475c46c18a647f18d342f5e2332e3) 
> # |            2: Target: x86_64-unknown-linux-gnu 
> # |            3: Thread model: posix 
> # |            4: InstalledDir: C:\b\s\w\ir\x\w\llvm_build\bin 
> # |            5: Build config: +assertions 
> # |            6:  "C:\\b\\s\\w\\ir\\x\\w\\llvm_build\\bin\\clang.exe" "-cc1" 
> "-triple" "x86_64-unknown-linux-gnu" "-emit-llvm-bc" "-flto=thin" 
> "-flto-unit" "-dumpdir" "a-" "-disable-free" "-clear-ast-before-backend" 
> "-main-file-name" "dtlto.c" "-mrelocation-model" "pic" "-pic-level" "2" 
> "-pic-is-pie" "-mframe-pointer=all" "-fmath-errno" "-ffp-contract=on" 
> "-fno-rounding-math" "-mconstructor-aliases" "-funwind-tables=2" 
> "-target-cpu" "x86-64" "-tune-cpu" "generic" "-debugger-tuning=gdb" 
> "-fdebug-compilation-dir=C:\\b\\s\\w\\ir\\x\\w\\llvm_build\\tools\\clang\\test\\Driver\\DTLTO"
>  
> "-fcoverage-compilation-dir=C:\\b\\s\\w\\ir\\x\\w\\llvm_build\\tools\\clang\\test\\Driver\\DTLTO"
>  "-resource-dir" "C:\\b\\s\\w\\ir\\x\\w\\llvm_build\\lib\\clang\\22" 
> "-internal-isystem" 
> "C:\\b\\s\\w\\ir\\x\\w\\llvm_build\\lib\\clang\\22\\include" 
> "-internal-isystem" "/usr/local/include" "-internal-externc-isystem" 
> "/include" "-internal-externc-isystem" "/usr/include" "-Werror" 
> "-ferror-limit" "19" "-fgnuc-version=4.2.1" "-fskip-odr-check-in-gmf" 
> "-faddrsig" "-D__GCC_HAVE_DWARF2_CFI_ASM=1" "-o" 
> "C:\\b\\s\\w\\ir\\x\\t\\lit-tmp-dw4aq672\\dtlto-029f91.o" "-x" "c" 
> "C:\\b\\s\\w\\ir\\x\\w\\llvm-llvm-project\\clang\\test\\Driver\\DTLTO\\dtlto.c"
>  
> # |            7:  "C:\\b\\s\\w\\ir\\x\\w\\llvm_build\\bin\\ld.lld" 
> "--hash-style=gnu" "--build-id" "--eh-frame-hdr" "-m" "elf_x86_64" "-pie" 
> "-dynamic-linker" "/lib64/ld-linux-x86-64.so.2" "-o" "a.out" "Scrt1.o" 
> "crti.o" "crtbeginS.o" "-plugin-opt=mcpu=x86-64" "-plugin-opt=thinlto" 
> "--thinlto-distributor=d.exe" 
> "--thinlto-remote-compiler=C:\\b\\s\\w\\ir\\x\\w\\llvm_build\\bin\\clang.exe" 
> "--thinlto-distributor-arg=a1" "--thinlto-distributor-arg=a2" 
> "--thinlto-distributor-arg=a3" 
> "C:\\b\\s\\w\\ir\\x\\t\\lit-tmp-dw4aq672\\dtlto-029f91.o" 
> "C:\\b\\s\\w\\ir\\x\\w\\llvm_build\\lib\\clang\\22\\lib\\x86_64-unknown-linux-gnu\\libclang_rt.builtins.a"
>  "--as-needed" "-lunwind" "--no-as-needed" "-lc" 
> "C:\\b\\s\\w\\ir\\x\\w\\llvm_build\\lib\\clang\\22\\lib\\x86_64-unknown-linux-gnu\\libclang_rt.builtins.a"
>  "--as-needed" "-lunwind" "--no-as-needed" "crtendS.o" "crtn.o" 
> # | same:17'0                                                                 
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>                         
> X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no 
> match found
> # | same:17'1                                                                 
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>                                                                    ?          
>            possible intended match
> # | >>>>>>
> # `-----------------------------
> # error: command failed with exit status: 1
> 
> --
> ```

Yes. Thanks. I'll do that now. The underlying issue that DLTTO doesn't work 
with Multicall is still present but I think that the test will pass now.

https://github.com/llvm/llvm-project/pull/159129
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to