sdardis accepted this revision. sdardis added a comment. This revision is now accepted and ready to land.
LGTM with a comment clarity tweak. ================ Comment at: lib/Driver/ToolChains/Gnu.cpp:2322-2323 case llvm::Triple::mips64el: - // Enabled for Debian mips64/mips64el only. Other targets are unable to - // distinguish N32 from N64. - if (getTriple().getEnvironment() == llvm::Triple::GNUABI64) + // Enabled for Debian mips64/mips64el and Android (uses N64 ABI). + // Other targets are unable to distinguish N32 from N64. + if (getTriple().getEnvironment() == llvm::Triple::GNUABI64 || ---------------- Enabled for Debian and Android mips64/mipsel, as they can precisely identify the ABI in use (Debian) or only use N64 for MIPS64 (Android). Other targets are unable to distinguish N32 from N64. Repository: rL LLVM https://reviews.llvm.org/D34514 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
