majnemer added inline comments.
================ Comment at: lib/AST/MicrosoftMangle.cpp:985 + + Out << '?' << Discriminate("_block_invoke", Discriminator) << '@'; + if (const auto *RD = dyn_cast<RecordDecl>(DC)) ---------------- Should this be `Out << '?' << mangleSourceName(Discriminate("_block_invoke", Discriminator));` ================ Comment at: lib/AST/MicrosoftMangle.cpp:990-994 + Out << "YAX"; + Out << "PA"; + mangleArtificalTagType(TTK_Struct, + Discriminate("__block_literal", Discriminator)); + Out << "@Z"; ---------------- You should probably add comments explaining these bits. Repository: rL LLVM https://reviews.llvm.org/D34523 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits