djasper added a comment.

I don't want to move forward with this patch. But adding Manuel as another 
reviewer to sanity-check.



================
Comment at: include/clang/Format/Format.h:167
+    /// \endcode
+    OAS_StrictAlign,
+  };
----------------
The name is not intuitive. I don't think this is any more or less strict than 
the other version.


================
Comment at: unittests/Format/FormatTest.cpp:2781
+  verifyFormat("return (a)\n"
+               "       // comment\n"
+               "     + b;",
----------------
Comment seems to belong to "+ b" so should be aligned to it.


https://reviews.llvm.org/D32478



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to