hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land.
Looks good, thanks! ================ Comment at: test/clang-tidy/misc-definitions-in-headers.hpp:1 -// RUN: %check_clang_tidy %s misc-definitions-in-headers %t +// RUN: %check_clang_tidy %s misc-definitions-in-headers %t -- -- -std=c++1z ---------------- xazax.hun wrote: > hokein wrote: > > hokein wrote: > > > The original code should work as `-std=c++11` will be added defaultly by > > > `check_clang_tidy` script. > > `constexpr` variables have internal linkage, which should be detected for > > the current check (but the test case is missing this kind of case). > > > > If you want to test `inline` variables, I'd suggest adding a new test file > > like `misc-definitions-in-headers-1z.hpp` which includes cases of inline > > variables. > It looks like `-std=c++11` is not added. OK. Yes, you are right. The `-std=c++11` only be added if the test file extension is `cpp`. I think we can extend the check_clang_tidy.py script to support it, but it can be done in a follow-up. https://reviews.llvm.org/D34449 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
