teemperor added a comment.

Two thought from me on this:

1. I think we want to support completing both -cc1 and normal driver 
invocation. Most people use the driver, but for example during debugging people 
use the cc1 version, so both are valid use cases. I just saw we actually have 
the completion code in the Driver, so what do you think about moving the code 
to the Frontend part and call it from the Driver/Frontend part?

2. I think it makes the most sense if we complete cc1 options but return 
"-Xclang OPTION" when we encounter a cc1 option from the Driver (because it's 
the least intrusive thing to do and the cc1 options are the ones everyone 
forgets about :) ).


https://reviews.llvm.org/D34770



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to