rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Sema/SemaDecl.cpp:13693-13694
+              // passes the structural compatibility check in C11 6.2.7/1.
+              bool AllowODR = getLangOpts().CPlusPlus || getLangOpts().ObjC1 ||
+                              getLangOpts().C11;
               NamedDecl *Hidden = nullptr;
----------------
I don't think this should require C11 -- in C89 the corresponding rule is in 
6.1.2.6/1, so the rule exists in all languages that Clang supports.


https://reviews.llvm.org/D31778



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D31778: [... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D317... Bruno Cardoso Lopes via Phabricator via cfe-commits
    • [PATCH] D317... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D317... Bruno Cardoso Lopes via Phabricator via cfe-commits

Reply via email to