gtbercea added inline comments.

================
Comment at: lib/Driver/Driver.cpp:564
+              auto &CudaTC =
+                  ToolChains[TT.str() + "/" + HostTC->getTriple().normalize()];
+              if (!CudaTC)
----------------
Hahnfeld wrote:
> The code above uses `HostTriple.str()`, maybe better align to this?
HostTriple is equivalent with HostTC->getTriple(). HostTC->getTriple() is only 
used once so no need for a local variable unless you want me to refactor the 
CUDA code above and take out HostTriple from within the if statement and then 
re0use HostTriple that way. I'd rather not make changes to the CUDA toolchain 
above.


https://reviews.llvm.org/D29658



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to