EricWF added a comment.
@dexonsmith Mind if I hijack this and check in your changes to `<functional>`
with my tests?
================
Comment at:
libcxx/test/libcxx/utilities/function.objects/func.wrap/func.wrap.func/func.wrap.func.con/move_reentrant.pass.cpp:1
+//===----------------------------------------------------------------------===//
+//
----------------
It seems like this test is testing behavior that should be required by the
standard, right?
If so it should live under `test/std`.
================
Comment at:
libcxx/test/libcxx/utilities/function.objects/func.wrap/func.wrap.func/func.wrap.func.con/move_reentrant.pass.cpp:25
+ ~A() {
+ asm("");
+ if (cancel)
----------------
Is `asm("")` just to prevent optimizations? If so please use `DoNotOptimize`
from `test_macros.h`.
https://reviews.llvm.org/D34331
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
