arphaman added a comment.

Thanks for the patch.
I have just one minor comment:



================
Comment at: tools/libclang/CIndex.cpp:7815
+  const Decl *D = cxcursor::getCursorDecl(C);
+  const EnumDecl *Enum = D ? dyn_cast_or_null<EnumDecl>(D) : nullptr;
+  return (Enum && Enum->isScoped()) ? 1 : 0;
----------------
`dyn_cast_or_null` already checks if `D` is null, so the ternary operator is 
redundant. You can also use `const auto *` once you use just the 
`dyn_cast_or_null`.


https://reviews.llvm.org/D35187



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to