This test was originally added in https://reviews.llvm.org/D34721 with clang change. It's kind of dup of the previous test (-check-prefix=SAMPLEPGO) in terms of testing the clang bits. But we want to make sure the new PM has the expected behavior. I guess it would be acceptable to remove one of them, but I'd prefer to remove the one with legacy PM. Let me know if you think I should do that.
Thanks, Dehao On Mon, Jul 10, 2017 at 9:45 AM, David Blaikie <dblai...@gmail.com> wrote: > Does this test any code in Clang? (given the test is being committed without > any change in Clang, I'm guessing maybe not) - perhaps this test doesn't > belong in Clang's test suite? > > Looks like changes/functionality in LTOPreLinkDefaultPipeline are tested in > test/Other/new-pm-thinlto-defaults.ll at least? > > On Fri, Jun 30, 2017 at 10:05 AM Dehao Chen via Phabricator via cfe-commits > <cfe-commits@lists.llvm.org> wrote: >> >> danielcdh created this revision. >> Herald added subscribers: eraman, inglorion, mehdi_amini, sanjoy. >> >> This patch should be enabled after https://reviews.llvm.org/D34895 >> >> >> https://reviews.llvm.org/D34896 >> >> Files: >> test/CodeGen/pgo-sample-thinlto-summary.c >> >> >> Index: test/CodeGen/pgo-sample-thinlto-summary.c >> =================================================================== >> --- test/CodeGen/pgo-sample-thinlto-summary.c >> +++ test/CodeGen/pgo-sample-thinlto-summary.c >> @@ -1,9 +1,7 @@ >> // RUN: %clang_cc1 -O2 >> -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm >> -o - 2>&1 | FileCheck %s -check-prefix=SAMPLEPGO >> // RUN: %clang_cc1 -O2 >> -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm >> -flto=thin -o - 2>&1 | FileCheck %s -check-prefix=THINLTO >> // RUN: %clang_cc1 -O2 -fexperimental-new-pass-manager >> -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm >> -o - 2>&1 | FileCheck %s -check-prefix=SAMPLEPGO >> -// FIXME: Run the following command once LTOPreLinkDefaultPipeline is >> -// customized. >> -// %clang_cc1 -O2 -fexperimental-new-pass-manager >> -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm >> -flto=thin -o - 2>&1 | FileCheck %s -check-prefix=THINLTO >> +// RUN: %clang_cc1 -O2 -fexperimental-new-pass-manager >> -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm >> -flto=thin -o - 2>&1 | FileCheck %s -check-prefix=THINLTO >> // Checks if hot call is inlined by normal compile, but not inlined by >> // thinlto compile. >> >> >> >> _______________________________________________ >> cfe-commits mailing list >> cfe-commits@lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits