owenca wrote: > As far as I can tell, what happened is @owenca committed a patch on Oct 17, > which broke a workflow for @PiJoules, which was reported on Oct 21. He asked > for a immediate fix/revert, which did not happen, then he reverted on Oct 22. > After that point, this turned into a revert war. Currently, the Oct 17 > patch is in.
Here is a recap of a more detailed timeline before @PiJoules escalated the issue to @llvm/clang-area-team: 1. On Oct 17, I committed a patch to revert/rework a previous commit that caused a regression as reported in #160513. The regression was important enough that the fix got backported to the 21.x branch on Oct 20 and released in clang-format 21.1.4 the next day. 2. On Oct 21, @PiJoules reported a bug that appeared to be caused by my Oct 17 commit and asked for a fix or revert. No word "immediate" or similar was used in the request. (See https://github.com/llvm/llvm-project/pull/164048#issuecomment-3429630861.) 3. I responded about 9 hours later and pointed out that that commit was already backported to 21.1.4. I indicated that I would try to come up with a fix in a few days. In the same comment, I also notified the reviewer @HazardyKnusperkeks of the commit how we might want to proceed and got a positive reply right away. 4. PiJoules reverted the commit about 9 hours later, which was questioned by HazardyKnusperkeks as to why the urgency. 5. I reverted PiJoules's revert after my investigation which concluded that the bug @PiJoules reported was not caused by my Oct 17 commit, and asked PiJoules to file a bug report. (See #164866.) https://github.com/llvm/llvm-project/pull/164670 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
