kwk wrote: > Thanks for working on this. Barring some minor changes, this LGTM.
Thank you for reviewing this. > Please change the title to `[flang][driver] Bring --gcc-triple to flang`. > This should also be the first line of the commit message. Done. > Out of curiosity, did the absence of `--gcc-triple` cause any problems? Yes, it caused a problem. In case of multiple gcc installations candidate, we couldn't select the right one by using a triple but instead had to specify the `--gcc-install-dir` which includes the gcc version information. In case the major gcc version changes we would have to rebuild llvm which isn't what we wanted. > Did you file an issue? No I didn't. Is that required in this case? Want me to create one? https://github.com/llvm/llvm-project/pull/165886 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
